perf - simplify codicon type - #170861
Merged
Merged
Conversation
Benjamin Pasero (bpasero)
enabled auto-merge (squash)
January 9, 2023 14:16
Benjamin Pasero (bpasero)
requested a review
from Martin Aeschlimann (aeschli)
January 9, 2023 14:17
Contributor
Author
|
If you have an idea how we could make |
Martin Aeschlimann (aeschli)
approved these changes
Jan 10, 2023
Contributor
|
Thanks Benjamin Pasero (@bpasero) ! Yes, the Codicon class is not really needed. I will follow up with a PR. |
Contributor
Author
|
Martin Aeschlimann (@aeschli) did that in #171234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed a GC kicking in for
codiconsgiven the sheer amount of instances created on startup:Using simple
stringremoves the GC for me:Besides, I find the code in
codiconStyles.tsvery questionable where we have an instance of check?