Skip to content

Add Pylance to languageServer setting enum#12788

Closed
joyceerhl wants to merge 2 commits into
microsoft:masterfrom
joyceerhl:pylance
Closed

Add Pylance to languageServer setting enum#12788
joyceerhl wants to merge 2 commits into
microsoft:masterfrom
joyceerhl:pylance

Conversation

@joyceerhl

Copy link
Copy Markdown

After a user installs Pylance, Pylance updates the python.languageServer setting to 'Pylance', which appears to not be a recognized option for that setting. The user sees this:
image

Just had a customer report this here: https://github.com/microsoft/vscode-python/issues/12751#issuecomment-654875902

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Jul 7, 2020
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikhailArkhipov

Copy link
Copy Markdown

Please don't merge just yet. This was intentional.

@joyceerhl
joyceerhl marked this pull request as draft July 7, 2020 16:56
@MikhailArkhipov

Copy link
Copy Markdown

#13123 takes over this

@joyceerhl joyceerhl closed this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants