[Copilot]

The Microsoft.VisualStudio.Threading.Analyzers package failed to load in VS 2022 with FileNotFoundException for System.Memory, Version=4.0.2.0. VS 2022 ships System.Memory 4.5.5 (assembly version 4.0.1.1), but the package version was pinned to 4.6.3 (assembly version 4.0.2.0), causing a binding failure at analyzer load time.

Changes

• Directory.Packages.props: Downgrade System.Memory pin from 4.6.3 → 4.5.5

The transitive dependency graph only required 4.5.4–4.5.5 (via Microsoft.CodeAnalysis.Common, System.Collections.Immutable, System.IO.Pipelines); the 4.6.3 pin was artificially inflated. All Memory/Span APIs used by the analyzers (ReadOnlyMemory<char>, ReadOnlySpan<char>, .AsMemory(), .AsSpan()) are present in 4.5.x. As a side effect, System.Buffers drops from 4.6.1 to 4.5.1, also aligning with what VS 2022 provides.

[Andrew Arnott (AArnott)]

Copilot This is good, but I want something that a dependency update bot won't immediately try to re-upgrade.
Consider how we solve this in https://github.com/microsoft/vs-streamjsonrpc/blob/main/Directory.Packages.props
Can you follow that model and verify that the dependencies remain satisfactory for roslyn analyzer projects?

[Copilot]

Copilot This is good, but I want something that a dependency update bot won't immediately try to re-upgrade.
Consider how we solve this in https://github.com/microsoft/vs-streamjsonrpc/blob/main/Dir...

Done in the latest commit. The approach mirrors vs-streamjsonrpc exactly:

1. src/Analyzers.props — sets IsAnalyzerProject=true
2. All 4 analyzer .csproj files — import Analyzers.props
3. Directory.Packages.props — global System.Memory stays at 4.6.3; a conditional ItemGroup with Condition="'$(IsAnalyzerProject)'=='true'" overrides it to 4.5.5 for analyzer builds only

A bot can now freely bump the global System.Memory version without breaking the VS 2022 analyzer load, since the conditional override keeps analyzer projects capped at 4.5.5 (assembly version 4.0.1.1, which is what VS 2022 ships). Verified that restoring the analyzer projects now resolves System.Memory/4.5.5.

[Copilot]

Pull request overview

This PR aims to fix a VS 2022 analyzer load failure caused by System.Memory assembly version mismatches by ensuring analyzer projects resolve a VS-host-compatible System.Memory package version during restore.

Changes:

• Adds src/Analyzers.props and imports it into the analyzer-related projects to mark them as analyzer projects.
• Introduces a conditional override in Directory.Packages.props intended to pin System.Memory to 4.5.5 for analyzer projects while keeping the repo-wide pin at 4.6.3.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Microsoft.VisualStudio.Threading.Analyzers/Microsoft.VisualStudio.Threading.Analyzers.csproj	Imports Analyzers.props to flag the project for analyzer-specific dependency pinning.
src/Microsoft.VisualStudio.Threading.Analyzers.VisualBasic/Microsoft.VisualStudio.Threading.Analyzers.VisualBasic.csproj	Imports Analyzers.props to flag the project for analyzer-specific dependency pinning.
src/Microsoft.VisualStudio.Threading.Analyzers.CSharp/Microsoft.VisualStudio.Threading.Analyzers.CSharp.csproj	Imports Analyzers.props to flag the project for analyzer-specific dependency pinning.
src/Microsoft.VisualStudio.Threading.Analyzers.CodeFixes/Microsoft.VisualStudio.Threading.Analyzers.CodeFixes.csproj	Imports Analyzers.props to flag the project for analyzer-specific dependency pinning.
src/Analyzers.props	Defines IsAnalyzerProject=true intended for conditional CPM overrides.
Directory.Packages.props	Adds an analyzer-only conditional override for System.Memory to 4.5.5.

[Amadeusz Wieczorek (AmadeusW)]

Approving with a comment