Add JoinableTaskContext.CreateNoOpContext() method - #1345
Merged
Conversation
Andrew Arnott (AArnott)
requested review from
Bertan Aygun (BertanAygun) and
Lifeng Lu (lifengl)
August 13, 2024 03:32
The `JoinableTaskContext` constructor unfortunately has a poor design where folks passing in `null` for the `SynchronizationContext` may mistakenly believe that they're getting a no-op instance when they aren't, if `SynchronizationContext.Current != null`. In this change, I add a method that *definitely* does what they expect. I also add an analyzer and a code fix provider to help identify code that was likely written with the incorrect expectation to help them switch to the new method which matches their expectation, or suppress the warning with a more clear syntax.
Andrew Arnott (AArnott)
force-pushed
the
jtcCtor
branch
from
August 13, 2024 16:23
56f10f3 to
d162c02
Compare
Bertan Aygun (BertanAygun)
approved these changes
Aug 13, 2024
This was referenced Jul 26, 2025
This was referenced Aug 7, 2025
This was referenced Oct 24, 2025
This was referenced Jan 17, 2026
Closed
This was referenced Jan 24, 2026
Closed
This was referenced Jan 31, 2026
Closed
This was referenced Feb 9, 2026
This was referenced Jun 17, 2026
This was referenced Jul 23, 2026
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JoinableTaskContextconstructor unfortunately has a poor design where folks passing innullfor theSynchronizationContextmay mistakenly believe that they're getting a no-op instance when they aren't, ifSynchronizationContext.Current != null.In this change, I add a method that definitely does what they expect.
I also add an analyzer and a code fix provider to help identify code that was likely written with the incorrect expectation to help them switch to the new method which matches their expectation, or suppress the warning with a more clear syntax.