This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Fix extension temp paths on macOS - #4910
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
August 17, 2026 20:37
Jake Bailey (jakebailey)
enabled auto-merge
August 17, 2026 20:38
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves macOS test failures caused by the temporary directory path containing symlinks.
Changes:
- Canonicalizes fixture paths with
fs.realpathSync.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Aug 17, 2026
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Aug 17, 2026
Jake Bailey (jakebailey)
added a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this since PRs don't run macOS; TMP on Macs is itself a symlink. (I did this correctly in the Go code testing symlinks, so, stealing that fix.)