Skip to content

Extract named cancellation-token data predicates - #12043

Merged
Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/code-simplifiercancellation-token-clarity-20261019
Oct 20, 2026
Merged

Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/code-simplifiercancellation-token-clarity-20261019

Conversation

Copilot AI commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Name the cancellation-token predicates used in tuple classification and data-driven display-name formatting, preserving their existing checks and evaluation order.

  • Tuple classification: Extract the full-arity tuple check into IsSingleTupleArgumentWithExplicitCancellationToken.
  • Display names: Move the explicit-token predicate into HasExplicitCancellationTokenData, retaining the existing tracked method signature.
&& !IsSingleTupleArgumentWithExplicitCancellationToken(data, parameters);

Copilot AI self-assigned this Oct 20, 2026
Copilot AI balanced review requested due to automatic review settings October 20, 2026 11:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 12:03
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI changed the title [WIP] [code-simplifier] Extract named helpers for cancellation-token data predicates Extract named cancellation-token data predicates Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow helper extractions preserve existing checks, evaluation order, and signatures.

No open issues 🎉

Review effort: Balanced

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review October 20, 2026 12:46
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Oct 20, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Oct 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 20, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 20, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Oct 20, 2026
@Evangelink
Amaury Levé (Evangelink) merged commit 5be524d into main Oct 20, 2026
30 of 31 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the copilot/code-simplifiercancellation-token-clarity-20261019 branch October 20, 2026 14:31
@github-actions github-actions Bot removed the state/approved Proposal approved; ready for implementation. label Oct 20, 2026
Amaury Levé (Evangelink) added a commit that referenced this pull request Oct 20, 2026
Resolve the overlap between #12043 and #12045 by retaining one unchanged IsSingleTupleArgumentWithExplicitCancellationToken definition. Removing the duplicate restores compilation, which otherwise fails with CS0111.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ba332d0f-f512-4fa7-80b6-9731c87a2c96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-simplifier] Extract named helpers for cancellation-token data predicates

4 participants