Repository navigation
Extract named cancellation-token data predicates - #12043
Merged
Amaury Levé (Evangelink) merged 3 commits intoOct 20, 2026
Merged
Amaury Levé (Evangelink) merged 3 commits into
Amaury Levé (Evangelink) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [code-simplifier] Extract named helpers for cancellation-token data predicates
Extract named cancellation-token data predicates
Oct 20, 2026
Amaury Levé (Evangelink)
marked this pull request as ready for review
October 20, 2026 12:46
Amaury Levé (Evangelink)
enabled auto-merge (squash)
October 20, 2026 12:46
Amaury Levé (Evangelink)
approved these changes
Oct 20, 2026
Petr Pokorny (0101)
approved these changes
Oct 20, 2026
Amaury Levé (Evangelink)
deleted the
copilot/code-simplifiercancellation-token-clarity-20261019
branch
October 20, 2026 14:31
Amaury Levé (Evangelink)
added a commit
that referenced
this pull request
Oct 20, 2026
Resolve the overlap between #12043 and #12045 by retaining one unchanged IsSingleTupleArgumentWithExplicitCancellationToken definition. Removing the duplicate restores compilation, which otherwise fails with CS0111. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ba332d0f-f512-4fa7-80b6-9731c87a2c96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name the cancellation-token predicates used in tuple classification and data-driven display-name formatting, preserving their existing checks and evaluation order.
IsSingleTupleArgumentWithExplicitCancellationToken.HasExplicitCancellationTokenData, retaining the existing tracked method signature.