Skip to content

Split Assert.Contains into focused partial files - #11788

Merged
Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/file-diet-refactor-assert-contains
Oct 7, 2026
Merged

Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/file-diet-refactor-assert-contains

Conversation

Copilot AI commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Refactor the 583-line Assert.Contains source into smaller files while preserving its public API and behavior.

  • Collections: Enumerable and array containment overloads.
  • Span and memory: Span, read-only span, memory, and read-only memory overloads.
  • Strings: Substring overloads and shared failure-reporting helpers.

Each file is under 300 lines.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unbalanced preprocessor and region directives currently prevent compilation.

Review effort: Balanced
Findings: 3 High severity

Open (3)

Copilot AI commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Build the repository

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:24
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 7, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Oct 7, 2026
Copilot AI changed the title [WIP] Refactor Assert.Contains.cs into focused partial-class files Split Assert.Contains into focused partial files Oct 7, 2026
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review October 7, 2026 09:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is a faithful structural split with no identified API or behavioral regression.

Review effort: Balanced
Findings: None

Resolved since last review (3)

@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Oct 7, 2026
@Evangelink
Amaury Levé (Evangelink) merged commit 754faca into main Oct 7, 2026
7 of 13 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the copilot/file-diet-refactor-assert-contains branch October 7, 2026 09:35
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[file-diet] Refactor Assert.Contains.cs (583 lines) into focused partial-class files

3 participants