Skip to content

Add direct tests for MSBuild IPC serializers - #11787

Merged
Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/test-improver-add-unit-tests
Oct 7, 2026
Merged

Amaury Levé (Evangelink) merged 3 commits into
mainfrom
copilot/test-improver-add-unit-tests

Conversation

Copilot AI commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

ModuleInfoRequestSerializer and RunSummaryInfoRequestSerializer lacked direct serializer-level coverage. Add focused tests against their PlatformMSBuild source-linked copies.

  • Protocol IDs: Verify both serializer IDs.
  • Module metadata: Round-trip all fields, including empty strings.
  • Run summary: Round-trip counts, duration, and AllowSkipped; verify null duration is normalized to an empty string.
  • Reflection lookup: Report clear errors if the embedded serializer methods cannot be found.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:23
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit tests for MSBuild serializers Add direct tests for MSBuild IPC serializers Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused test-only change covers the intended serializer behavior without introducing unresolved issues.

Review effort: Balanced
Findings: None

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review October 7, 2026 09:32
@Evangelink
Amaury Levé (Evangelink) merged commit d49a16a into main Oct 7, 2026
5 of 11 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the copilot/test-improver-add-unit-tests branch October 7, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-improver] Add unit tests for MSBuild ModuleInfoRequest/RunSummaryInfoRequest serializers

3 participants