Skip to content

Improve MTP core mutation coverage - #11734

Merged
Amaury Levé (Evangelink) merged 5 commits into
mainfrom
dev/amauryleve/fix-mtp-surviving-mutants
Oct 5, 2026
Merged

Amaury Levé (Evangelink) merged 5 commits into
mainfrom
dev/amauryleve/fix-mtp-surviving-mutants

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Mutation testing for the configured Microsoft.Testing.Platform core modules had 156 surviving mutants, leaving important edge cases and protocol behavior insufficiently verified. This change adds focused tests that exercise those paths and applies narrow Stryker suppressions only where mutations are equivalent or platform-specific.

The changes cover ServerMode process and protocol behavior plus MSBuild task generation, tool resolution, configuration, stack traces, executable parsing, Unicode boundaries, and duration suffix parsing.

Validation

  • Microsoft.Testing.Platform.ServerMode.Client.Sources: 856 killed, 0 survived.
  • Microsoft.Testing.Platform.MSBuild: 543 killed, 0 survived.
  • ServerMode client unit tests: 283 passed, 8 skipped, 0 failed.
  • Platform MSBuild unit tests: 198 passed, 0 failed.
  • Binary-logged targeted builds passed.
  • git diff --check passed.

Add focused tests and targeted mutation suppressions for equivalent or platform-specific behavior in the configured MTP core modules.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 3, 2026 20:44
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Oct 3, 2026
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) October 3, 2026 20:47

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Summary

This PR is a mutation-testing hardening pass over Microsoft.Testing.Platform.MSBuild (DotnetMuxerLocator, InvokeTestingPlatformTask, StackTraceHelper, UnicodeCharacterUtilities, TestingPlatformAutoRegisteredExtensions), the shared StackTraceRegexHelper, and MtpServerInProcessHost, plus a large batch of new/expanded unit tests for all of the above and for TimeSpanParser, ErrorCodes/InitializeRequestArgs serialization, and MtpServerProcess. No public API, IPC wire format, or localization resources are touched.

Dimensions reviewed: Algorithmic correctness, threading/concurrency, security/IPC safety, public API, performance, cross-TFM, resource management, localization, test isolation, assertion quality, flakiness patterns, test completeness, data-driven coverage, code structure, naming, documentation accuracy, scope discipline.

Findings

  • StackTraceHelper.TryGetStackFrameLocation (src, production code): the inlined place = match.Groups["code"].Value correctly drops the dead code1-fallback branch, since TryGetStackFrameLocation is only ever invoked with matchFramesWithoutLocation: false (confirmed via GetOrCreateRegex), where the code1 group can never participate in a successful match. No regression.
  • Stryker disable once ... comments added across DotnetMuxerLocator*.cs, InvokeTestingPlatformTask*.cs, TestingPlatformAutoRegisteredExtensions.cs, UnicodeCharacterUtilities.cs, StackTraceRegexHelper.cs, TimeSpanParser.cs, and MtpServerInProcessHost.cs: spot-checked each rationale against the surrounding logic (e.g. TimeSpanParser's day-suffix branch is unreachable without the regex having already matched a day alias; UnicodeCharacterUtilities's <= '\u007F' check is provably equivalent to the Unicode-category path for that one code point; the Mach-O magic/cigam byte-order mapping is paired per architecture). All checked comments are accurate and explain why the mutant is semantically equivalent rather than just suppressing noise — consistent with documentation-accuracy guidance.
  • Null-forgiving operator change in InvokeTestingPlatformTask.ToolResolution.cs (.. EnvironmentVariables! instead of .. EnvironmentVariables ?? []): this is reached only inside the if (hasExplicitDotnetRoot || hasExplicitWindowsX86DotnetRoot) branch, and both flags are computed via ContainsEnvironmentVariable(...) which returns false whenever EnvironmentVariables is null, so EnvironmentVariables is guaranteed non-null at that point. The ??[] on the line below (reached only when neither flag is set) is correctly left untouched since EnvironmentVariables can still be null there. Safe, and improves mutation-coverage precision without behavior change.
  • New tests (DotnetMuxerLocatorTests, InvokeTestingPlatformTaskTests, MSBuildTests, StackTraceHelperTests, UnicodeCharacterUtilitiesTests/TimeSpanParserTests, MtpServerClientInProcessTests, MtpServerProcessTests, ProtocolMutationTests, SerializationMutationTests): use TestMethod/DataRow, reflection against private statics where needed, IsolatedAssemblyLoadContext for one-time-initialization assertions (correctly Unload()'d in finally), and polling (SpinWait.SpinUntil, bounded retry loop in AssertPortCanBeReboundAsync) rather than fixed sleeps for the port-rebind and process-tree checks — consistent with the flakiness-avoidance guidance. The SafeKillTerminatesEntireProcessTree change adds a readyFile rendezvous instead of relying on Start-Sleep -Seconds 2 alone, which removes a prior race rather than introducing one.
  • StackTraceHelperTests.TryFindLocationFromStackFrame_InitializesRegexWithBoundedTimeout: resets the cached s_regex static field to null before invoking TryFindLocationFromStackFrame, then re-reads it. This is a shared static touched by other tests in the same class; the assembly is marked [assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)], and Workers = 0 disables actual parallel execution for this assembly, so there is no live cross-test race today — but flagging for awareness: if Workers is ever changed to a positive value, this test would race with any other test in the class that depends on StackTraceHelper's cached regex instance. No action required given current config.

No blocking, major, or moderate defects identified. The dependency-upgrade-assessment template does not apply (no eng/Versions.props or package-reference changes in this diff).

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 3, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused tests and suppressions align with the stated mutation-coverage goals without introducing observable compatibility or correctness regressions.

Review effort: Balanced
Findings: None

What changed in this PR

Adds focused mutation coverage for MTP ServerMode and MSBuild components while suppressing platform-specific or equivalent mutants.

Changes:

  • Expands protocol, process, configuration, generation, parsing, and tool-resolution tests.
  • Simplifies stack-frame extraction for location-only regexes.
  • Adds narrowly scoped Stryker suppressions.

Confidence at a glance

🟢 ServerMode and MSBuild Reviewed lifecycle, serialization, platform-specific, parsing, and test-isolation changes; no blocking issues found.
File Description
SerializationMutationTests.cs Tests client-assembly deserialization.
ProtocolMutationTests.cs Verifies protocol error codes in isolation.
MtpServerProcessTests.cs Strengthens cleanup and process-tree tests.
MtpServerClientInProcessTests.cs Covers failed-start synchronization behavior.
UnicodeCharacterUtilitiesTests.cs Adds duration parsing coverage.
StackTraceHelperTests.cs Covers regex construction and initialization.
MSBuildTests.cs Expands task-generation and configuration tests.
InvokeTestingPlatformTaskTests.cs Covers output, environment, and pipe behavior.
DotnetMuxerLocatorTests.cs Adds PE boundaries and muxer-name coverage.
StackTraceRegexHelper.cs Suppresses equivalent resource-lookup mutants.
TimeSpanParser.cs Suppresses the equivalent final-suffix mutant.
MtpServerInProcessHost.cs Documents equivalent context-capture mutation.
UnicodeCharacterUtilities.cs Suppresses equivalent ASCII-boundary mutants.
TestingPlatformEntryPointTask.cs Suppresses unsafe debugger-hook mutation.
TestingPlatformAutoRegisteredExtensions.cs Suppresses debugger and grouping mutants.
StackTraceHelper.cs Removes unreachable fallback group handling.
InvokeTestingPlatformTask.ToolResolution.cs Clarifies nullability and boundary suppression.
InvokeTestingPlatformTask.cs Suppresses platform and debugger mutants.
DotnetMuxerLocator.MacOs.cs Suppresses equivalent byte-order mutation.
DotnetMuxerLocator.cs Suppresses platform-specific OS mutations.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 3, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 3, 2026
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Final test-triage resolution — Azure Pipelines build 1622317

Analysis is final (completed aggregate build, microsoft.testfx check).

Actionable failure: Constructor_UsesPlatformSpecificPipeName (Linux Release, net8.0 + net9.0)

This is a new test added by this PR (test/UnitTests/Microsoft.Testing.Platform.MSBuild.UnitTests/InvokeTestingPlatformTaskTests.cs) and it fails deterministically on Linux for both target frameworks:

Assertion failed. Expected string to contain the specified substring.
expected substring: "testingplatform.pipe."
actual:             "/tmp/7bdddd678aa94243b1f8586a17496ebd"
Assert.Contains(Prefix, pipeName)

Root cause: the test's Unix branch asserts Assert.Contains(Prefix, pipeName) where Prefix = "testingplatform.pipe.", but NamedPipeServer.GetPipeName (in src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs) builds the Unix pipe path as Path.Combine(directory, name) where name is the raw GUID (e.g. 7bdddd678aa94243b1f8586a17496ebd) with no testingplatform.pipe. prefix segment — that prefix is only applied on the Windows branch ($"testingplatform.pipe.{name...}"). So on Unix the resulting path never contains the literal prefix string; only the filename format (a bare 32-char GUID "N" form) matches. The test's own fallback assertion two lines later (Assert.StartsWith(Prefix, fileName) on Path.GetFileName(pipeName)) correctly reflects this but is unreachable because the preceding Assert.Contains throws first.

  • Confidence: high — deterministic logic mismatch between test and implementation, reproducible on every Linux run in this build (both TFMs), not environment-dependent.
  • Affected matrix: Linux Release only (net8.0, net9.0); Windows legs pass because the Windows branch of GetPipeName does include the literal prefix.
  • Not flaky/historical: this is a brand-new test with no prior build history to compare against.
  • Next step: fix the new test's Unix branch to assert on fileName (e.g. drop the Assert.Contains(Prefix, pipeName) check, or assert the prefix against Path.GetFileName(pipeName) as the later lines already do) rather than the full path.

Non-actionable: PackagedWinUI.PackagedWinUITestCases.RetryTestMethod_PassesOnSecondAppContainerHost

Fails on attempt 1, passes on attempt 2 in this build — and in all 10 available prior builds in history.json (including unrelated commits on main), with the same assertion ("The first AppContainer host fails so Retry must activate a second host."). This matches the test's own name and intent (verifying retry behavior that intentionally fails the first host), so it is working as designed and not related to this PR.

No issue is warranted for the retry test (consistent, by-design first-attempt failure, not a regression). An issue is warranted for the pipe-name test defect since it is a deterministic code/test bug, but since it was introduced by this same PR and is fixable by the PR author directly, filing a separate tracking issue is not necessary — please address it in this PR before merge.

Build: Azure Pipelines build 1622317 (Linux Release leg).

🤖 Automated content by GitHub Copilot. Generated by the Pipeline Test Triage workflow. · copilot · auto · 158.5 AIC · ⌖ 6.87 AIC · ⊞ 9.6K

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Oct 5, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Oct 5, 2026
…p-surviving-mutants

# Conflicts:
#	src/Platform/Microsoft.Testing.Platform/Helpers/TimeSpanParser.cs
Remove the reflection assertion for the deleted InvalidHandleValue field after merging the latest main branch.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:46
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/approved Proposal approved; ready for implementation. labels Oct 5, 2026
Use an explicit null check before StartsWith to avoid nullable lifting and the redundant Boolean comparison.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/approved Proposal approved; ready for implementation. labels Oct 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A non-equivalent synchronization mutant is suppressed, and the PE boundary tests preserve an off-by-one error.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 5, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Oct 5, 2026
Cover zero-timeout cleanup context capture, fix the PE signature offset boundary, and align pipe-name assertions with Unix behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 11:10
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/approved Proposal approved; ready for implementation. labels Oct 5, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 5, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Oct 5, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 5, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Oct 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The runner-name suppression hides observable mutants and undermines the stated zero-survivor coverage result.

Review effort: Balanced
Findings: None

Resolved since last review (2)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Narrow broad mutation suppression in runtime initializer test

src/​Platform/​Microsoft.Testing.Platform.MSBuild/​Tasks/​InvokeTestingPlatformTask.cs:19

disable once all also excludes observable mutants in the active branch, not just the inactive platform literal. For example, on Unix changing "dotnet" or selecting "dotnet.exe" would make EmbeddedRuntimeDefaults_AreInitializedInFreshAssembly fail (and the reverse is true on Windows), so the reported zero-survivor result no longer measures this behavior. Please narrow the suppression—e.g. move platform-name selection into a helper that accepts isWindows and test both inputs—rather than suppressing every mutant on this initializer.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Test quality review — PR #11734

🧵 Parallel safety

STATUS: CLEAN. Both touched assemblies (Microsoft.Testing.Platform.MSBuild.UnitTests, Microsoft.Testing.Platform.ServerMode.Client.Sources.UnitTests) run MethodLevel parallelization with no [ResourceLock]/[DoNotParallelize] declarations added, removed, or weakened. All new/modified tests use per-test GUID temp dirs/files and ephemeral ports. The one process-global mutation (TESTINGPLATFORM_DEFAULT_HANG_TIMEOUT env var in EmbeddedRuntimeDefaults_AreInitializedInFreshAssembly, MSBuildTests.cs:722-750) is correctly guarded by [ResourceLock(WellKnownResources.EnvironmentVariables)] with capture/restore in a finally block. No Critical/High/Warning/Info findings.

Per-test grades

All 30 new or materially-modified test methods in this PR graded A. Highlights: the DotnetMuxerLocator PE-header boundary tests (RejectsOffsetJustPastLastReadableSignature, OffsetAtLastReadableSignature(InMinimalHeader)_IsNotClassifiedAsInvalidOffset) precisely pin the peHeader > fs.Length - sizeof(uint) off-by-one guard; the StackTraceRegexHelper/StackTraceHelper additions pin the exact compiled regex pattern and RegexOptions.Compiled flag; the cross-assembly ErrorCodes/Json reflection tests in ProtocolMutationTests/SerializationMutationTests verify the client-compiled copy of shared source stays wire-compatible with the server; and the MSBuild task tests (EntryPointTask_GeneratesEveryTemplateBranch, SelfRegisteredExtensions_GeneratesEveryLanguageAndNamespaceBranch) use MSTest's native [DataRow] table-driven pattern to cover every language/namespace/host-factory branch with strong value + message-log assertions and an explicit "no Stryker survivor" marker check. No assertion-strength, anti-pattern, or pseudo-mutation gaps were found; the per-branch conditional assertions in the two template-branch tests are accepted as idiomatic data-driven table tests rather than penalized as unstructured conditional logic.

GradeTestMutationNotesHow to improve
A (90–100)new DotnetMuxerLocatorTests.
GetMuxerArchitectureByPEHeaderOnWin_
RejectsOffsetJustPastLastReadableSignature
2/2 killedPins the exact off-by-one boundary (peHeader > length - 4) with two DataRow cases straddling the edge.—
A (90–100)new DotnetMuxerLocatorTests.
GetMuxerArchitectureByPEHeaderOnWin_
OffsetAtLastReadableSignature_
IsNotClassifiedAsInvalidOffset
1/1 killedConfirms the valid boundary offset is not misclassified as invalid.—
A (90–100)new DotnetMuxerLocatorTests.
GetMuxerArchitectureByPEHeaderOnWin_
OffsetAtLastReadableSignatureInMinimalHeader_
IsNotClassifiedAsInvalidOffset
1/1 killedDistinguishes "invalid offset" from "missing PE signature" at the minimal-header boundary.—
A (90–100)new DotnetMuxerLocatorTests.
Constructor_UsesPlatformSpecificMuxerName
1/1 killedReflects on _muxerName and asserts the OS-specific value, killing the Stryker-flagged conditional.—
A (90–100)mod InvokeTestingPlatformTaskTests.
LogEventsFromTextOutput_AzureDevOpsCommands_
AreWrittenToStdoutAtColumnZero_NotThroughMSBuildLog
1/1 killedNew assertion confirms both AzDO and normal lines always reach the captured _output buffer.—
A (90–100)new InvokeTestingPlatformTaskTests.
AddAppHostDotnetRootEnvironmentVariable_
WithNoUserVariables_
AddsOnlyResolvedVariableAndLogsIt
2/2 killedVerifies both the resulting environment variable and the low-importance log message.—
A (90–100)new InvokeTestingPlatformTaskTests.
AddAppHostDotnetRootEnvironmentVariable_
UsesRequestedEnvironmentVariableComparison
2/2 killedExercises both the Windows (ordinal-ignore-case) and non-Windows (ordinal) comparison branches.—
A (90–100)new InvokeTestingPlatformTaskTests.
Constructor_UsesPlatformSpecificPipeName
2/2 killedBranches on path separator to assert the OS-appropriate pipe-name shape and embedded GUID.—
A (90–100)new MSBuildTests.
EntryPointTask_GeneratesEveryTemplateBranch
N/A20 DataRows cover every language/namespace/host-factory/entry-point combination with value + log assertions.—
A (90–100)new MSBuildTests.
EntryPointTask_AcceptsMinimalQualifiedHostFactoryAndIdentifierCharacters
1/1 killedConfirms minimal valid identifiers are accepted and correctly embedded in generated source.—
A (90–100)new MSBuildTests.
EntryPointTask_RejectsInvalidCharactersInsideHostFactoryIdentifiers
1/1 killedAsserts the exact error message and that no file is written on validation failure.—
A (90–100)new MSBuildTests.
EntryPointTask_SanitizesRootNamespaceForNonVisualBasicLanguages
2/2 killedConfirms namespace sanitization for both C# and F#.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_Fails_
WhenOneDuplicateMetadataValueDiffers
2/2 killedCovers both metadata fields that can trigger the conflicting-duplicate error.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_
GeneratesEveryLanguageAndNamespaceBranch
N/A5 DataRows cover every language/namespace combination with generated-call and log assertions.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_
FSharpWithoutHooks_EmitsUnitExpression
2/2 killedConfirms the empty-hooks F# branch emits a unit expression and skips the hook-list log.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_
SanitizesRootNamespaceForNonVisualBasicLanguages
2/2 killedConfirms namespace sanitization for both C# and F# extension generation.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_
StopsAfterFirstConflictingDuplicate
1/1 killedAsserts exactly one error is reported, confirming early termination on first conflict.—
A (90–100)new MSBuildTests.
SelfRegisteredExtensions_
MissingMetadata_ReportsExpectedItemSpec
2/2 killedCovers both required metadata fields and asserts the exact diagnostic item-spec text.—
A (90–100)new MSBuildTests.
ConfigurationFileTask_
MissingSourceAndDefaults_
ProducesNoOutputAndExactDiagnostics
1/1 killedAsserts the exact ordered diagnostic message sequence for the missing-source path.—
A (90–100)new MSBuildTests.
ConfigurationFileTask_
MissingSourceAndEmptyDefaults_ProducesNoOutput
1/1 killedConfirms the empty-defaults path also logs the not-found message as the last entry.—
A (90–100)new MSBuildTests.
EmbeddedRuntimeDefaults_
AreInitializedInFreshAssembly
1/1 killedReflection across an isolated AssemblyLoadContext pins embedded default constants; env var is saved/restored under [ResourceLock].—
A (90–100)new MSBuildTests.
ConfigurationFileTask_
CopiesExistingSourceAndLogsEveryResolvedPath
1/1 killedAsserts the full ordered log sequence and the copied-file content/path equality.—
A (90–100)new MSBuildTests.
ConfigurationFileTask_
AllowsCommentsAndTrailingCommasAndWritesIndentedJson
1/1 killedVerifies JSON-with-comments parsing, indentation, trailing newline, and comment stripping.—
A (90–100)mod StackTraceHelperTests.
TryFindLocationFromStackFrame_
InitializesRegexWithBoundedTimeout
2/2 killedNew assertions pin the Compiled flag and the exact regex pattern string.—
A (90–100)new StackTraceHelperTests.
CreateFrameRegexPattern_
WithOptionalLocation_MatchesBothFrameShapes
1/1 killedAsserts the exact alternation pattern and both match/no-match frame shapes with captured groups.—
A (90–100)new StackTraceHelperTests.
CreateFrameRegexPattern_
WithRequiredLocation_ProducesExactPattern
1/1 killedPins the exact required-location pattern string.—
A (90–100)new TimeSpanParserTests.
TryParse_BareNumber_UsesMilliseconds
1/1 killedConfirms the no-suffix default-unit dispatch to milliseconds.—
A (90–100)new TimeSpanParserTests.
TryParse_ExplicitSuffix_
ParsesInvariantNumber
1/1 killedConfirms fractional seconds parse with invariant culture.—
A (90–100)new TimeSpanParserTests.
TryParse_MillisecondAliases_
UseMilliseconds
2/2 killedCovers both the ms and mil-prefix disambiguation branches ahead of the minute prefix.—
A (90–100)new TimeSpanParserTests.
TryParse_MinuteSuffix_UsesMinutes
1/1 killedConfirms the minute-suffix branch.—
A (90–100)new TimeSpanParserTests.
TryParse_HourSuffix_UsesHours
1/1 killedConfirms the hour-suffix branch.—
A (90–100)new TimeSpanParserTests.
TryParse_DaySuffix_UsesDays
1/1 killedConfirms the fallthrough day-suffix branch.—
A (90–100)new MtpServerClientInProcessTests.
LaunchInProcessAsync_
ZeroTimeoutFailedStartCleanup_
DoesNotCaptureTheCallingSynchronizationContext
1/1 killedReuses the class's established sync-context-pumping pattern; asserts no capture plus the exact timeout-failure message.—
A (90–100)mod ProtocolMutationTests.
ErrorCodes_
MatchTheJsonRpcAndTestingProtocol
12/12 killedNow also loads the client-compiled ErrorCodes copy via an isolated AssemblyLoadContext and asserts wire-value parity with the server.—
A (90–100)mod SerializationMutationTests.
Json_DeserializeInitializeRequest_
ValidatesProtocolVersionEntries
2/2 killedRefactored to deserialize through the client assembly's own Json type, verifying the client's validation/exception behavior directly.—

This advisory review is heuristic and non-blocking.

Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · 548.3 AIC · ⌖ 8.89 AIC · ⊞ 17.9K · ◷

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 5, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Oct 5, 2026
@Evangelink
Amaury Levé (Evangelink) merged commit 7d36b85 into main Oct 5, 2026
39 of 42 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-mtp-surviving-mutants branch October 5, 2026 12:26
@github-actions github-actions Bot removed the state/approved Proposal approved; ready for implementation. label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants