Skip to content

Retarget modern UWP sample to .NET 10 - #11650

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/retarget-modern-uwp-sample
Sep 30, 2026
Merged

Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/retarget-modern-uwp-sample

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Retarget the public modern UWP MTP sample to net10.0-windows10.0.26100.0 now that #11609 supports the .NET 10 AppX recipe layout.

Update the sample README and related Windows application testing guidance to remove the obsolete .NET 9 limitation. The copy-ready desktop-MSBuild commands are preserved, and the docs clarify that the .NET 10 SDK supplies target framework/SDK resolution while Visual Studio desktop MSBuild supplies the UWP XAML/MSIX toolchain.

Validation

  • build.cmd -pack -c Release -bl: succeeded with 0 warnings and 0 errors.
  • eng\build-samples.ps1 -Configuration Release -BinaryLogDirectory artifacts\log\Release\retarget-uwp-samples-fresh -LocalPackageDirectory artifacts\packages\Release\Shipping -LocalMSTestVersion 4.5.0-dev -LocalTestingPlatformVersion 2.5.0-dev with an isolated NuGet cache: 16/16 public sample solutions succeeded.
  • Visual Studio 2026 desktop MSBuild 18.11 with .NET SDK 10.0.112: UwpMtpApp.sln /restore /t:Build succeeded for net10.0-windows10.0.26100.0.
  • Desktop-MSBuild InvokeTestingPlatform with the short physical registration staging used by Fix .NET 10 modern UWP MTP invocation #11609's acceptance coverage: TRX reported 2/2 passed:
    • PackageIdentityMatchesManifest
    • UITestMethodRunsOnTheCoreWindowDispatcher

Follow-up to #11609.

Update the public sample and related guidance now that the packaged-app launcher supports net10 modern UWP execution.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 07:53
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused retargeting is internally consistent, documented, and covered by existing .NET 10 acceptance validation.

Review effort: Balanced
Findings: None

What changed in this PR

Retargets the modern UWP MTP sample to .NET 10 and updates associated guidance.

Changes:

  • Changes the sample target framework to net10.0-windows10.0.26100.0.
  • Removes obsolete .NET 9 launcher limitations from documentation.
  • Clarifies desktop MSBuild and .NET SDK responsibilities.
File Description
samples/​public/​UwpMtpApp/​UwpMtpApp.csproj Retargets the sample to .NET 10.
samples/​public/​UwpMtpApp/​README.md Updates prerequisites and tooling guidance.
samples/​public/​README.md Updates the public sample overview.
docs/​winui-testing.md Updates modern UWP examples to .NET 10.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 30, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Final test-triage resolution — Azure Pipelines build 1617551

This is a docs/sample-only PR (retargets the UWP sample to .NET 10); neither failure is related to the changed files.

1. StartAsyncTimeoutKillsProcessAndReleasesListener (Windows Release, Microsoft.Testing.Platform.ServerMode.Client.Sources.UnitTests) — failed once in this build. History shows this test passed in all 3 recent occurrences collected. The failure message shows the child process exited cleanly (exited with code 0 before connecting back) instead of hitting the intended 300 ms connection timeout — a timing race between the process's own completion and the timeout check, not a change caused by this PR. This matches an already-tracked flake: #11631 ("Flaky: MtpServerProcessTests.StartAsyncTimeoutKillsProcessAndReleasesListener races between timeout and early-exit failure"). No new issue created; treating as a known duplicate occurrence.

2. PackagedWinUI.PackagedWinUITestCases.RetryTestMethod_PassesOnSecondAppContainerHost (Windows Release App-Model Diagnostics leg) — failed on first attempt, passed on retry. This test is intentionally designed to fail on its first AppContainer host activation and pass on the second (RETRY_TEST marker-file logic), verifying the retry mechanism itself. History shows the identical fail-then-pass pattern in every recent build sample (7/7) where the test ran. This is expected behavior of the test, not a regression or flake needing action.

Confidence: high for both — no code/product defect, no action needed on this PR beyond the existing tracked issue #11631. No new issue created (duplicate of open, actionable #11631; second finding is by-design retry-mechanism behavior).

🤖 Automated content by GitHub Copilot. Generated by the Pipeline Test Triage workflow. · copilot · auto · 71.9 AIC · ⌖ 5.59 AIC · ⊞ 9.6K

@Evangelink
Amaury Levé (Evangelink) merged commit 5f191f5 into main Sep 30, 2026
27 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/retarget-modern-uwp-sample branch September 30, 2026 09:33
@github-actions github-actions Bot removed the state/approved Proposal approved; ready for implementation. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants