Skip to content

Refactor duplicated base64-encoded retry-artifact manifest logic - #11574

Merged
Amaury Levé (Evangelink) merged 8 commits into
mainfrom
copilot/duplicate-code-fix
Sep 29, 2026
Merged

Amaury Levé (Evangelink) merged 8 commits into
mainfrom
copilot/duplicate-code-fix

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
  • Extract retry-artifact manifest limits and encoding into one shared-source helper
  • Migrate PackagedApp and Retry to the shared protocol implementation
  • Update focused tests for the shared behavior
  • Run targeted build/tests and review the final diff
  • Scan changed files and complete code/security validation

Copilot AI balanced review requested due to automatic review settings September 28, 2026 06:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 28, 2026 06:51
Copilot AI and others added 4 commits September 28, 2026 06:53
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The actual report-side manifest writer still duplicates encoding and null-sentinel logic outside the shared implementation.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Sep 28, 2026
@Evangelink Amaury Levé (Evangelink) changed the title [WIP] Refactor duplicated base64-encoded retry-artifact manifest logic Refactor duplicated base64-encoded retry-artifact manifest logic Sep 28, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Sep 28, 2026
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 28, 2026 09:42
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The newly centralized writer protocol lacks tests that would detect delimiter, encoding, or null-sentinel regressions.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Sep 28, 2026
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review September 28, 2026 17:12
@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 28, 2026 17:21
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The refactoring preserves the wire format, covers every consumer, and includes focused tests for the shared behavior.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)

@Evangelink
Amaury Levé (Evangelink) merged commit 4a6bd80 into main Sep 29, 2026
22 of 26 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the copilot/duplicate-code-fix branch September 29, 2026 06:33
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[duplicate-code] Duplicate Code: Base64-encoded retry-artifact manifest parsing/writing duplicated across PackagedApp and Retry extensions

3 participants