Repository navigation
Consolidate TestFramework string escaping - #11446
Merged
Amaury Levé (Evangelink) merged 4 commits intoSep 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 of 7 tasks
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicate C#-style string/char escaping logic
Consolidate TestFramework string escaping
Sep 22, 2026
Amaury Levé (Evangelink)
marked this pull request as ready for review
September 22, 2026 11:41
Add test for rendering quote and backslash characters. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
approved these changes
Sep 22, 2026
Amaury Levé (Evangelink)
enabled auto-merge (squash)
September 22, 2026 11:41
Petr Pokorny (0101)
approved these changes
Sep 22, 2026
Contributor
|
Final test-triage resolution — Azure Pipelines build 1607034 Analysis is final (completed aggregate build).
Conclusion: This build failure is an environmental worker-timeout on the non-blocking macOS leg, not a test-product regression. No durable-issue threshold is met (no repeated signature, no code/test defect evidence). No action beyond a possible pipeline re-run is warranted.
|
Amaury Levé (Evangelink)
disabled auto-merge
September 23, 2026 12:49
Amaury Levé (Evangelink)
deleted the
copilot/duplicate-code-issue-resolution
branch
September 23, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

C#-style string and character escaping was duplicated across DataRow display names, assertion value rendering, and string-difference diagnostics, allowing their implementations to drift.
StringEscapeHelperas the single source of truth for escape classification, rendering, matching, length calculation, and surrogate detection.AssertionValueRendererstring/character surrogate rendering and built-in rendering detection.