Skip to content

Deduplicate extension pipe server setup - #10858

Merged
Amaury Levé (Evangelink) merged 1 commit into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-issue-10855
Aug 31, 2026
Merged

Amaury Levé (Evangelink) merged 1 commit into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-issue-10855

Conversation

@Evangelink

Copy link
Copy Markdown
Member

HangDump and TrxReport duplicated the setup required for controller-authorized, single-connection named pipe servers. This centralizes endpoint creation, authorization wiring, and effective pipe-name publication in a shared linked helper while preserving each extension's assembly-local IPC types.

Fixes #10855

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c0b3d1a-83b6-443b-b299-0dbb04c6d95c
Copilot AI balanced review requested due to automatic review settings August 29, 2026 07:35
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) August 29, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Centralizes authorized single-connection named-pipe setup shared by HangDump and TRX reporting.

Changes:

  • Adds a shared endpoint/server factory.
  • Migrates both extensions to the factory.
  • Updates linked sources and internal API baselines.
File Description
SharedExtensionHelpers/​NamedPipeServerFactory.cs Implements shared pipe setup.
TrxReport/​TrxReportExtensions.cs Uses shared endpoint creation.
TrxReport/​TrxProcessLifetimeHandler.cs Uses shared server binding.
TrxReport/​Microsoft.Testing.Extensions.TrxReport.csproj Links the helper.
TrxReport/​InternalAPI/​InternalAPI.Unshipped.txt Tracks helper APIs.
HangDump/​HangDumpExtensions.cs Uses shared endpoint creation.
HangDump/​HangDumpProcessLifetimeHandler.cs Uses shared server binding.
HangDump/​Microsoft.Testing.Extensions.HangDump.csproj Links the helper.
HangDump/​InternalAPI/​InternalAPI.Unshipped.txt Tracks helper APIs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 29, 2026
@Evangelink
Amaury Levé (Evangelink) merged commit 88d2de0 into microsoft:main Aug 31, 2026
23 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-issue-10855 branch August 31, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[duplicate-code] Duplicate Code: NamedPipeServer construction/endpoint pattern in HangDump & TrxReport lifetime handlers

3 participants