Repository navigation
Deduplicate extension pipe server setup - #10858
Merged
Amaury Levé (Evangelink) merged 1 commit intoAug 31, 2026
Merged
Amaury Levé (Evangelink) merged 1 commit into
Amaury Levé (Evangelink) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c0b3d1a-83b6-443b-b299-0dbb04c6d95c
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Centralizes authorized single-connection named-pipe setup shared by HangDump and TRX reporting.
Changes:
- Adds a shared endpoint/server factory.
- Migrates both extensions to the factory.
- Updates linked sources and internal API baselines.
| File | Description |
|---|---|
SharedExtensionHelpers/NamedPipeServerFactory.cs |
Implements shared pipe setup. |
TrxReport/TrxReportExtensions.cs |
Uses shared endpoint creation. |
TrxReport/TrxProcessLifetimeHandler.cs |
Uses shared server binding. |
TrxReport/Microsoft.Testing.Extensions.TrxReport.csproj |
Links the helper. |
TrxReport/InternalAPI/InternalAPI.Unshipped.txt |
Tracks helper APIs. |
HangDump/HangDumpExtensions.cs |
Uses shared endpoint creation. |
HangDump/HangDumpProcessLifetimeHandler.cs |
Uses shared server binding. |
HangDump/Microsoft.Testing.Extensions.HangDump.csproj |
Links the helper. |
HangDump/InternalAPI/InternalAPI.Unshipped.txt |
Tracks helper APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Petr Pokorny (0101)
approved these changes
Aug 31, 2026
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HangDump and TrxReport duplicated the setup required for controller-authorized, single-connection named pipe servers. This centralizes endpoint creation, authorization wiring, and effective pipe-name publication in a shared linked helper while preserving each extension's assembly-local IPC types.
Fixes #10855