Skip to content

Add ArtifactPostProcessingHelper ordering tests - #10766

Merged
Amaury Levé (Evangelink) merged 1 commit into
microsoft:mainfrom
Evangelink:evangelink-test-artifact-order-inputs
Aug 26, 2026
Merged

Amaury Levé (Evangelink) merged 1 commit into
microsoft:mainfrom
Evangelink:evangelink-test-artifact-order-inputs

Conversation

@Evangelink

Copy link
Copy Markdown
Member

ArtifactPostProcessingHelper.OrderInputs provides the deterministic ordering shared by report artifact post-processors, but its multi-key behavior had no direct unit coverage.

Add focused reflection-based tests that verify the metadata-enabled five-key ordering, the metadata-disabled execution ID ordering, and full-path normalization for equivalent relative and absolute paths. The reflection approach targets the TrxReport copy without introducing ambiguous references to the linked helper type.

Fixes: #10746

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 557aee88-cacd-4ee9-a36c-85645560b30c
Copilot AI balanced review requested due to automatic review settings August 26, 2026 08:34
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) August 26, 2026 08:40
@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds direct unit coverage for deterministic artifact input ordering.

Changes:

  • Tests metadata-enabled and metadata-disabled sorting.
  • Verifies relative/full-path normalization.
  • Reuses reflection to target the TrxReport-linked helper.
Show a summary per file
File Description
ArtifactPostProcessingHelperTests.cs Adds focused ordering tests and reflection helpers.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@Evangelink
Amaury Levé (Evangelink) merged commit b5f3c2f into microsoft:main Aug 26, 2026
38 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink-test-artifact-order-inputs branch August 26, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-improver] Add unit tests for ArtifactPostProcessingHelper.OrderInputs

3 participants