Repository navigation
Add RetryArtifactProcessor.ProcessAsync unit tests - #10579
Conversation
Add focused coverage for processor selection, matching, completeness, replacement bookkeeping, warning behavior, and cancellation semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds focused unit coverage for retry artifact processing and related artifact handling.
Changes:
- Tests processor selection, matching, validation, ordering, and replacement bookkeeping.
- Covers warning, continuation, and cancellation behavior.
- Adds reusable test setup helpers and post-processor fake.
Show a summary per file
| File | Description |
|---|---|
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/RetryTests.cs |
Expands retry artifact processor unit coverage. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
🧪 Expert test review — PR #10579Reviewed the 11 new test methods added to Overall quality is high: each test isolates a single branch (guard clauses, ordering, kind/extension matching, validation failure + continuation, cancellation vs. unrelated-cancellation warning paths), uses
No high-confidence, inline-actionable findings beyond the one B-grade note above (which is a readability/clarity suggestion, not a correctness bug — the assertion itself is correct for both platforms). No inline suggestion was posted since the improvement is a structural refactor (splitting into two tests) rather than a single-line mechanical edit. This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Re-run with
|
🧵 Parallel-safety audit — PR #10579Parallelization — assembly audited:
Findings: A (global-state)
No changes to Advisory only — heuristic, non-blocking. Re-run with
|
Summary
Testing
.\build.cmd -projects test\UnitTests\Microsoft.Testing.Extensions.UnitTests\Microsoft.Testing.Extensions.UnitTests.csproj -bl.\.dotnet\dotnet.exe test test\UnitTests\Microsoft.Testing.Extensions.UnitTests\Microsoft.Testing.Extensions.UnitTests.csproj -c Debug --no-build --no-restore -bl:artifacts\log\Debug\RetryArtifactProcessor.AllTfms.binlognet462,net472,net8.0, andnet9.0Closes #10578