You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Trx and Ctrf post-processors can throw for dangling merged-directory links #10733
TrxArtifactPostProcessor and CtrfArtifactPostProcessor call Directory.CreateDirectory for the fixed merged output directory without handling file-system failures. On Linux, a dangling directory symbolic link at that path causes Directory.CreateDirectory to throw IOException, allowing artifact post-processing to fail the test run instead of returning no merged artifact.
This conflicts with RFC 018's requirement that post-processing failures must not fail the run. The HTML and JUnit post-processors already handle IOException and UnauthorizedAccessException for this operation.
Version used
Current main branch.
Steps To Reproduce
On Linux, create an artifact post-processing output directory.
Create a dangling directory symbolic link named merged inside it.
Invoke either TrxArtifactPostProcessor.ProcessAsync or CtrfArtifactPostProcessor.ProcessAsync with two valid inputs.
Observe that Directory.CreateDirectory(mergedDirectory) throws IOException.
Expected behavior
The processor returns null, preserves the input artifacts, and does not fail the test run.
Actual behavior
An IOException escapes from artifact post-processing.
Additional context
Discovered while reviewing #10731, which adds equivalent dangling-link regression coverage for the HTML post-processor. The fix should align Trx and Ctrf with the existing HTML/JUnit fail-closed behavior and add mutation-sensitive tests at both call sites.
Activity