schema: Allow verbose no-argument actions in the settings schema#20430
Open
Weichenleeeee123 wants to merge 1 commit into
Open
schema: Allow verbose no-argument actions in the settings schema#20430Weichenleeeee123 wants to merge 1 commit into
Weichenleeeee123 wants to merge 1 commit into
Conversation
Weichenleeeee123
marked this pull request as ready for review
July 16, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
FullCommand.command.References and Relevant Issues
Closes #11332
Detailed Description of the Pull Request / Additional comments
Windows Terminal accepts both of these forms:
{ "command": "toggleAlwaysOnTop" } { "command": { "action": "toggleAlwaysOnTop" } }The settings schema only accepted the short form because
FullCommand.commandhad no object branch for actions without arguments.
This adds a strict
NoArgsActiondefinition for the 39 argument-free actions.It also connects the existing
AddMarkAction,SetFocusModeAction,SetFullScreenAction, andSetMaximizedActiondefinitions, which were notreferenced by
FullCommand.command.Validation Steps Performed
Validated
doc/cascadia/profiles.schema.jsonwith PowerShell 7.6Test-Json:git diff --checkpasses.PR Checklist