Repository navigation
Fix PEM certificate handling for secure boot defaults - #476
Open
CHEA Oudomrasmey (thekingq20) wants to merge 1 commit into
Open
CHEA Oudomrasmey (thekingq20) wants to merge 1 commit into
CHEA Oudomrasmey (thekingq20) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
Member
|
Thanks for looking at this! Can you rebase against main and ensure line endings are consistent and force push? There are a lot of changes that are not associated directly with your change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PEM certificate files were not reliably recognized or decoded by the secure boot default key generator. This change extracts the base64 payload from PEM armor, validates decoding, accepts
.pemand.cerextensions, and adds regression coverage. It also makes revocation-list selection skip filenames without numeric version suffixes instead of failing on them.The workspace changes include line-ending normalization across multiple files, which accounts for much of the diff volume.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
C:\Users\the20\AppData\Local\Programs\Python\Python312\python.exe -m pytest -qIntegration Instructions
N/A