Skip to content

fix(web-storage): workaround autolinking issues - #3200

Merged
Tommy Nguyen (tido64) merged 1 commit into
mainfrom
tido/web-storage/workaround-autolinking
Jun 20, 2024
Merged

fix(web-storage): workaround autolinking issues#3200
Tommy Nguyen (tido64) merged 1 commit into
mainfrom
tido/web-storage/workaround-autolinking

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Jun 20, 2024

Copy link
Copy Markdown
Member

Description

Workaround for autolinking not including macOS or Windows as target platforms (see react-native-community/cli#2419)

Test plan

In RNTA:

yarn
cd node_modules/@react-native-webapis/web-storage
yarn react-native codegen-windows

# This command will fail as is
# Now add `react-native-windows` to `package.json`

yarn react-native codegen-windows

# This should succeed

@github-actions github-actions Bot added the feature: webapis This is related to the experimental effort around WebAPIs for RN label Jun 20, 2024
@tido64
Tommy Nguyen (tido64) merged commit 386ddce into main Jun 20, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/web-storage/workaround-autolinking branch June 20, 2024 14:42
@tido64 Tommy Nguyen (tido64) mentioned this pull request Jul 4, 2024
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes
@JasonVMo Jason Morse (JasonVMo) Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees

No one assigned

Labels

feature: webapis This is related to the experimental effort around WebAPIs for RN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @acoates-ms