Repository navigation
Fixes bug introduced by e7735a8 - #8820
Merged
2 commits merged intoOct 13, 2021
Merged
2 commits merged into
2 commits merged into
Conversation
In order to properly set the `pageX` and `pageY` values in `TouchEventHandler`, we need to ensure the root view is set, which is used to calculate these properties. By default, the root view is not provided to the `TouchEventHandler` so we should treat the supplied `xamlView` argument as the root view.
Nick Gerleman (NickGerleman)
approved these changes
Oct 12, 2021
Nick Gerleman (NickGerleman)
added
the
AutoMerge
|
Hello Nick Gerleman (@NickGerleman)! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 53 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
removed
the
AutoMerge
Nick Gerleman (NickGerleman)
added
the
AutoMerge
Member
|
Original PR: #7813 |
Jon Thysell (jonthysell)
approved these changes
Oct 12, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to properly set the
pageXandpageYvalues inTouchEventHandler, we need to ensure the root view is set, which isused to calculate these properties. By default, the root view is not provided to the
TouchEventHandlerso we should treat the suppliedxamlViewargument as the root view. The root view is only supplied for selectable text, where the target XamlView is still a child of the root view, so we need to differentiate where event propagation should stop from the root view the target point is being measured against.Microsoft Reviewers: Open in CodeFlow