Repository navigation
fix(android): introduce upper Gradle wrapper versions - #2133
Merged
Tommy Nguyen (tido64) merged 3 commits intoJul 22, 2024
Merged
Conversation
Gradle 8.9 removes APIs that are still being used by 0.75 (see react/react-native@b82d7e1)
Tommy Nguyen (tido64)
requested review from
Saad Najmi (Saadnajmi) and
acoates-ms
July 19, 2024 06:32
Tommy Nguyen (tido64)
requested a review
from Jason Morse (JasonVMo)
as a code owner
July 19, 2024 06:32
22 of 30 tasks
Jason Morse (JasonVMo)
approved these changes
Jul 19, 2024
Jason Morse (JasonVMo)
left a comment
Jason Morse (JasonVMo)
left a comment
There was a problem hiding this comment.
Nit on the if statements but not blocking, just a comment for the future.
Tommy Nguyen (tido64)
deleted the
tido/android/fix-gradle-wrapper-versions
branch
July 22, 2024 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gradle 8.9 removes APIs that are still being used by 0.75.
Build log: https://github.com/microsoft/react-native-test-app/actions/runs/9993761517/job/27621913498
Fixed upstream in react/react-native@b82d7e1.
Platforms affected
Test plan
React Native versions and the Gradle version ranges that is supported:
Test cases should cover these.
To manually test them:
set-react-versionto set thereact-nativeversionexample/android/gradle/wrapper/gradle-wrapper.propertiesexample/android:./gradlew assembleDebug