Skip to content

fix(apple): fix crash on startup on 0.75 + New Arch - #2127

Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/ios/fix-bridgeless-startup
Jul 17, 2024
Merged

fix(apple): fix crash on startup on 0.75 + New Arch#2127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/ios/fix-bridgeless-startup

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Jul 16, 2024

Copy link
Copy Markdown
Member

Description

Fix crash on startup on 0.75 + New Arch caused by accessing ReactNativeFeatureFlags before overrides are set.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.75 -- --core-only
yarn
cd example
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

@tido64 Tommy Nguyen (tido64) mentioned this pull request Jul 16, 2024
Closed
22 of 30 tasks
@github-actions github-actions Bot added platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS labels Jul 16, 2024
@tido64
Tommy Nguyen (tido64) merged commit 6debf33 into trunk Jul 17, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/ios/fix-bridgeless-startup branch July 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonVMo Jason Morse (JasonVMo) JasonVMo approved these changes
@Saadnajmi Saad Najmi (Saadnajmi) Awaiting requested review from Saadnajmi Saadnajmi is a code owner

Assignees

No one assigned

Labels

platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @JasonVMo