fix(android): automatically configure Gradle wrapper - #1935
Merged
Merged
Conversation
Tommy Nguyen (tido64)
requested a review
from Lorenzo Sciandra (kelset)
as a code owner
March 25, 2024 23:22
Tommy Nguyen (tido64)
force-pushed
the
tido/manage-gradle-version
branch
from
March 26, 2024 08:18
1c7cc3a to
1687f97
Compare
2 of 6 tasks
To disable this behavior, set `RNTA_CONFIGURE_GRADLE_WRAPPER=0`.
Tommy Nguyen (tido64)
force-pushed
the
tido/manage-gradle-version
branch
from
March 26, 2024 10:14
1687f97 to
5d788b8
Compare
Lorenzo Sciandra (kelset)
approved these changes
Mar 26, 2024
Lorenzo Sciandra (kelset)
left a comment
Contributor
There was a problem hiding this comment.
Good stuff!
Tested the whole flow locally and it works great.
Let's ![]()
Tommy Nguyen (tido64)
enabled auto-merge (squash)
March 26, 2024 16:16
28 of 33 tasks
9 of 24 tasks
4 of 20 tasks
7 of 23 tasks
11 of 25 tasks
20 of 34 tasks
8 of 20 tasks
7 of 14 tasks
11 of 17 tasks
5 of 14 tasks
5 of 14 tasks
8 of 14 tasks
3 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatically configure Gradle wrapper. To disable this behavior, set
RNTA_CONFIGURE_GRADLE_WRAPPER=0.Basically, this is what the script does:
Platforms affected
Test plan
npm run set-react-version 0.71 -- --core-onlyexample/android/gradle/wrapper/gradle-wrapper.propertiesis unmodifiedyarncd example && yarn androidexample/android/gradle/wrapper/gradle-wrapper.properties)npm run set-react-version 0.73 -- --core-onlyyarncd example && yarn androidnpm run set-react-version 0.72 -- --core-onlyyarncd example && yarn androidnpm run set-react-version 0.71 -- --core-onlyyarncd example && RNTA_CONFIGURE_GRADLE_WRAPPER=0 yarn android