Skip to content

fix(android): handle simplified ReactActivityDelegate - #1900

Merged
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/fix-android-nightly
Mar 14, 2024
Merged

fix(android): handle simplified ReactActivityDelegate#1900
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/fix-android-nightly

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Android nightly build is failing because ReactActivityDelegate was simplified in react/react-native@3283202:

> Task :app:compileDebugKotlin FAILED
e: file:///~/node_modules/react-native-test-app/android/app/src/reactactivitydelegate-0.74/java/com/microsoft/reacttestapp/component/ComponentActivityDelegate.kt:24:5 'createRootView' overrides nothing

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version nightly
yarn
cd example
yarn android

# In a separate terminal
yarn start

Screenshots

Screenshot_1710409294

@github-actions github-actions Bot added the platform: Android This affects Android label Mar 14, 2024
@tido64 Tommy Nguyen (tido64) mentioned this pull request Mar 14, 2024
Closed
22 of 30 tasks
kelset
Lorenzo Sciandra (kelset) approved these changes Mar 14, 2024
View reviewed changes

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, all works and changes LGTM 👍

@tido64
Tommy Nguyen (tido64) merged commit 0014a92 into trunk Mar 14, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/fix-android-nightly branch March 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kelset Lorenzo Sciandra (kelset) kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: Android This affects Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @kelset