Skip to content

fix: declare support for 0.74 - #1863

Merged
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/0.74
Mar 19, 2024
Merged

fix: declare support for 0.74#1863
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/0.74

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Feb 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Declare support for react-native@0.74

Status of 74 is here: React Native 0.74 Releases

Resolves #1656.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run test:matrix 0.74

Screenshots

Configuration JSC Hermes Fabric Fabric + Hermes
Android n/a Screenshot-Android-hermes n/a Screenshot-Android-hermes-fabric-concurrent
iOS Screenshot-iOS Screenshot-iOS-hermes Screenshot-iOS-fabric-concurrent Screenshot-iOS-hermes-fabric-concurrent

@tido64

Tommy Nguyen (tido64) commented Feb 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

0.74.0-rc.0

@tido64
Tommy Nguyen (tido64) force-pushed the tido/0.74 branch 4 times, most recently from 5854078 to 8208325 Compare February 27, 2024 13:11
@tido64

Tommy Nguyen (tido64) commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

0.74.0-rc.1

@tido64
Tommy Nguyen (tido64) force-pushed the tido/0.74 branch 3 times, most recently from 4cb7371 to 73f8023 Compare February 29, 2024 12:05
@tido64

Tommy Nguyen (tido64) commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

0.74.0-rc.2/-rc.3/-rc.4

npm run test:matrix 0.74 completes successfully

@tido64
Tommy Nguyen (tido64) force-pushed the tido/0.74 branch 5 times, most recently from 974f5cf to f47801f Compare March 15, 2024 09:59
@tido64
Tommy Nguyen (tido64) marked this pull request as ready for review March 18, 2024 17:48
kelset
Lorenzo Sciandra (kelset) approved these changes Mar 19, 2024
View reviewed changes

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the script locally, all ✅

I think that given the trajectory of the last RCs that have all worked out just fine, we can assume that it's relatively stable and we should be fine going ahead and merging this ahead of 0.74.0

@tido64
Tommy Nguyen (tido64) merged commit 319764b into trunk Mar 19, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/0.74 branch March 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kelset Lorenzo Sciandra (kelset) kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for react-native 0.74

2 participants

@tido64 @kelset