Skip to content

fix(android): get Kotlin version from react-native - #1845

Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/android-kotlin-version
Feb 16, 2024
Merged

Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/android-kotlin-version

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Feb 15, 2024 •

Copy link
Copy Markdown
Member

Description

Upstream recently bumped Kotlin to 1.9:

ksp-1.8.22-1.0.11 is too old for kotlin-1.9.22. Please upgrade ksp or downgrade kotlin-gradle-plugin to 1.8.22.

Build log: https://github.com/microsoft/react-native-test-app/actions/runs/7910899026/job/21594219403

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

gradle/libs.versions.toml was first introduced in 0.73 so we need to test 0.72, 0.73, and nightly.

# Build nightly
npm run set-react-version nightly
yarn
cd example/android
./gradlew assembleDebug

# Build 0.72
cd ..
npm run set-react-version 0.72 -- --core-only
yarn clean
yarn
cd example/android
./gradlew assembleDebug

# 0.73 is already built by CI

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, all works as expected 👍

changes look good to me, liked the dependencies map

@tido64
Tommy Nguyen (tido64) merged commit 5289200 into trunk Feb 16, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/android-kotlin-version branch February 16, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Android This affects Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants