Skip to content

fix(android): use default app setup for New Arch - #1774

Merged
Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/use-default-rnh
Jan 19, 2024
Merged

Tommy Nguyen (tido64) merged 2 commits into
trunkfrom
tido/use-default-rnh

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Jan 16, 2024 •

Copy link
Copy Markdown
Member

Description

Use default app setup for New Arch as it includes a lot of the things that we had to manually implement. Incidentally, this also fixes the crash we had on startup with 0.74 + New Arch.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Run the following for 0.71, 0.74:

npm run set-react-version 0.71
sed -i '' 's/#newArchEnabled/newArchEnabled/' example/android/gradle.properties
yarn
cd example
yarn android

# In a separate terminal
yarn start

Screenshots

0.71 0.72 0.74
Screenshot_1705418147 Screenshot_1705417852 Screenshot_1705418519

@kelset

Copy link
Copy Markdown
Contributor

Tested, here are the screenshots:

0.71 0.72 0.74
Screenshot_1705675500 Screenshot_1705675952 Screenshot_1705677330

had to jump through a few hoops like the macos problem we are having with their nightlies - but aside from that it all works.

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tido64
Tommy Nguyen (tido64) merged commit 558a6e1 into trunk Jan 19, 2024
@tido64
Tommy Nguyen (tido64) deleted the tido/use-default-rnh branch January 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Android This affects Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants