iOS: Unable to install reanimated #1195

Activity

1. Ragnar Rebase (rrebase)

   changed the title [-]Unable to install reanimated[/-] [+]iOS: Unable to install reanimated[/+] on Nov 7, 2022
2. tido64 commented on Nov 7, 2022

   

   Tommy Nguyen (tido64)

   on Nov 7, 2022

   Member

   More actions

   Hi Ragnar Rebase (@rrebase), what version of react-native are you using? Are you building with new arch enabled? Do you have a minimal repro I can have a look at? I don't think I've seen this issue before.
3. rrebase commented on Nov 7, 2022

   

   Ragnar Rebase (rrebase)

   on Nov 7, 2022

   Last edited by rrebase

   Author

   More actions

   options = {
     :hermes_enabled => true,
     :fabric_enabled => false,
     :turbomodule_enabled => false,
   }
   

   RN versions 0.68.2 & 0.70.0. I'll prepare a minimal repro 🙂

   👍React with 👍1Reacted by Tommy Nguyen
4. rrebase commented on Nov 7, 2022

   

   Ragnar Rebase (rrebase)

   on Nov 7, 2022

   Last edited by rrebase

   Author

   More actions

   Minimal repro https://github.com/rrebase/react-native-test-app/tree/reanimated-demo

   👀React with 👀1Reacted by Tommy Nguyen
5. tido64 commented on Nov 7, 2022

   

   Tommy Nguyen (tido64)

   on Nov 7, 2022

   Last edited by tido64

   Member

   More actions

   Ragnar Rebase (@rrebase): I managed to repro it. I also found this issue: software-mansion/react-native-reanimated#3420

   There's a workaround posted here: software-mansion/react-native-reanimated#2791 (comment)

   I tried it and it seems to be working:

   

   I'm not sure what's going on though. But it doesn't seem like it's an issue with react-native-test-app in particular. It seems like installTurboModule() is making some assumptions that isn't always true.

   Update: I had a closer look at how installTurboModule() works and it's quite… hacky, to say the least. This is not a reliable way to install a custom runtime at all, and it's basically polluting all classes inheriting from UIResponder. Since it is a fairly popular package, I think we will have to support it somehow if upstream can't come up with a better solution. Definitely not like this though.

   👍React with 👍1Reacted by Lorenzo Sciandra

   ❤️React with ❤️1Reacted by Ragnar Rebase
6. tido64 commented on Nov 10, 2022

   

   Tommy Nguyen (tido64)

   on Nov 10, 2022

   Member

   More actions

   I put up a PR with a proposal for a fix. It leverages config plugins to install the Reanimated runtime. I still need to do more testing, but would love to hear your feedback on it.

   🚀React with 🚀1Reacted by Ragnar Rebase
7. Tommy Nguyen (tido64)

   closed this as completedin #1197on Nov 29, 2022