Repository navigation
Getting rid of the legacy JS integration in favor of JSI with V8 impl… - #224
Merged
Merged
Conversation
Anandraj (mganandraj)
requested review from
a team,
BarinderGrewal,
acoates-ms,
Yichen Yao (hansenyy),
rohitjain85,
tudorms and
Vladimir Morozov (vmoroz)
January 16, 2020 02:25
|
Eric Rozell (rozele)
pushed a commit
to rozele/react-native-macos
that referenced
this pull request
Dec 4, 2025
Summary: Pull Request resolved: react#54741 Changelog: [Internal] - Update `react-native/debugger-frontend` from 7f25433...4631a6d Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](react/react-native-devtools-frontend@7f25433...4631a6d). ### Changelog | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [4631a6d5d](react/react-native-devtools-frontend@4631a6d5d) | Ruslan Lesiutin (28902667+hoxyq@users.noreply.github.com) | 2025-12-01T18:05:33Z | [feat(timeline): display newly supported options for Timeline (microsoft#224)](react/react-native-devtools-frontend@4631a6d5d) | Reviewed By: huntie Differential Revision: D88082538 fbshipit-source-id: 2a7f178415915cfea7739efa99d21e5d2b3d178d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
With this change, i'm trying to cleanup a lot of differences that we've managed to accumulate over the last couple of years in JS engine integration. Specifically, we had our own implementation of JSEExecutor interface called V8Executor (Just like CHakraExecutor on Win32/UWP). And we used to switch between V8Executor and JSCExecutor. The switch and the V8Executor remained even though JSCExecutor already went away, which made the switch useless, but most of the code remained which clutterd our build scripts.
With this change, i originally intented to remove the switch and cleanup the build scripts. But, in the process, it felt a lot more efficient to get rid of the V8Executor and switch to JSI engines altogether, as the FB repo (even v0.60.0) has only JSI based executors now. It'd be a backward step to even keep the V8Executor around.
Hence, with this change, we take a big stride forward, by switching to V8 based JSI runtime exclusively. I've already tested RNTester, Modern commenting and LPC already.
This change may a bit aggressive, but i think this will help us a lot in the long time with maintainabiltiy and even performance. Now that we are going to switch to JSI runtimes in Windows very soon, this change will help us to unify the JSI implementation across platforms.
There is a small change in Office code required which i'll send a CR for androidxupgrade override.
Focus areas to test
SDX functionalities.
Microsoft Reviewers: Open in CodeFlow