Repository navigation
Account for duplicate-on-drag and shadows in keyboard disconnect (X) - #11381
Merged
Richard Knoll (riknoll) merged 2 commits intoJun 9, 2026
Merged
Richard Knoll (riknoll) merged 2 commits into
Richard Knoll (riknoll) merged 2 commits into
Conversation
For duplicate on drag blocks we clone the block like we already do for move (M). Change how we clone as it's important for undo that the block is a non-shadow from the beginning otherwise the create undo event is skipped. The shadow part of the precondition works around this blockly issue which I've opened an upstream PR for: RaspberryPiFoundation/blockly#9963
Richard Knoll (riknoll)
approved these changes
Jun 9, 2026
Richard Knoll (riknoll)
enabled auto-merge (squash)
June 9, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For duplicate on drag blocks we clone the block like we already do for move (M).
Change how we clone as it's important for undo that the block is a non-shadow from the beginning otherwise the create undo event is skipped.
The shadow part of the precondition works around this blockly issue which I've opened an upstream PR for:
RaspberryPiFoundation/blockly#9963