Migrate from winapi to windows-rs

[George Pollard (Porges)]

windows-rs is the newer, Microsoft-supported version of the API bindings; winapi hasn't been updated in some time. This allows us to remove some code, as windows-rs includes the Sym* functions that we had to previously defined ourselves in dbghelp.

Rather than port the jobs and com code I removed it, as it was unused.

The check_hr and check_winapi macros have been replaced by use of .ok()? on BOOL and ? on HRESULT which now support standard error handling facilities.

[Codecov Comments Bot (codecov-commenter)]

Codecov Report

Merging #3050 (9562975) into main (3851ab0) will decrease coverage by 1.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
- Coverage   34.68%   32.94%   -1.74%     
==========================================
  Files         302      269      -33     
  Lines       36923    31289    -5634     
==========================================
- Hits        12806    10308    -2498     
+ Misses      24117    20981    -3136     

Files Changed	Coverage Δ
src/agent/onefuzz-agent/src/worker.rs	48.63% <ø> (+1.16%)	⬆️
src/agent/onefuzz/src/memory.rs	61.11% <ø> (+36.11%)	⬆️

... and 55 files with indirect coverage changes

[George Pollard (Porges)]

I've checked coverage output with check-pr, which is the main thing that I would expect to be affected by this change.

[shuffle2]

Just cloned this repo and tried to build with winapi v0.3.9. The build (of src\agent\coverage) is broken as synchapi and impl-default aren't enabled. So I guess this PR would be nice as it should happen to fix the build too :)

[George Pollard (Porges)]

Just cloned this repo and tried to build with winapi v0.3.9. The build (of src\agent\coverage) is broken as synchapi and impl-default aren't enabled. So I guess this PR would be nice as it should happen to fix the build too :)

The issue here is that it depends on what level in the repo you build at. If you build src/agent then all the features of winapi which we need are enabled, since cargo will union them all together. However, some of the subcrates use features without enabling them (for example, I just fixed one over here), so you might get failures if you build an individual crate. This is annoying to detect in the CI build since we'd have to build each crate individually rather than just building the whole workspace...