Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

We should probably make the Render function non-async. Looking at the implementation, we invoke Template.RenderAsync, but we aren't benefiting from any async IO here (we are working entirely in-memory), we could invoke Template.Render instead, and this would simplify all the callers (like this bit of code). #3235

Closed

Description

@tevoinea
          We should probably make the `Render` function non-async. Looking at the implementation, we invoke `Template.RenderAsync`, but we aren't benefiting from any async IO here (we are working entirely in-memory), we could invoke `Template.Render` instead, and this would simplify all the callers (like this bit of code).

Originally posted by George Pollard (@Porges) in #3227 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions