Repository navigation
Define runtime adapter message codes once - #738
Open
Matthew (theworker02) wants to merge 1 commit into
Open
Matthew (theworker02) wants to merge 1 commit into
Matthew (theworker02) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized refactor preserves existing behavior, adds no dependencies, and has no unresolved review findings.
No open issues 🎉
What changed in this PR
Centralizes runtime adapter message codes in Kind, addressing #665 while preserving the existing wire format.
Changes:
- Defines each code once using explicit
#[repr(u8)]discriminants. - Encodes kinds with a cast and decodes bytes by searching the complete kind list.
| File | Description |
|---|---|
tests/runtime-adapter/src/frame.rs |
Removes duplicate numeric mappings while preserving all five codes and unknown-code rejection. |
Review effort: Balanced
Pedro Henrique Penna (ppenna)
requested changes
Oct 22, 2026
| 5 => Some(Self::Stopped), | ||
| _ => None, | ||
| } | ||
| Self::ALL.into_iter().find(|kind| kind.code() == code) |
Contributor
There was a problem hiding this comment.
Simple constant definition and reuse would avoid linear time here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses explicit #[repr(u8)] discriminants so each wire code has one definition and decoding derives from the complete set of kinds.\n\nValidation:\n- cargo fmt --all --check\n- cargo clippy --locked --all-targets -- -D warnings\n- cargo test --locked\n- git diff --check\n\nCloses #665.