Repository navigation
Reject unrepresentable sandbox resource limits - #735
Merged
Pedro Henrique Penna (ppenna) merged 2 commits intoOct 21, 2026
Merged
Pedro Henrique Penna (ppenna) merged 2 commits into
Pedro Henrique Penna (ppenna) merged 2 commits into
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Pedro Henrique Penna (ppenna)
requested review from
Enrique Saurez (esaurez) and
Pedro Henrique Penna (ppenna)
and
a balanced review from Copilot
October 21, 2026 20:13
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
Pedro Henrique Penna (ppenna)
approved these changes
Oct 21, 2026
Pedro Henrique Penna (ppenna)
enabled auto-merge
October 21, 2026 21:56
Pedro Henrique Penna (ppenna)
approved these changes
Oct 21, 2026
Pedro Henrique Penna (ppenna)
approved these changes
Oct 21, 2026
Pedro Henrique Penna (ppenna)
removed the request for review
from Enrique Saurez (esaurez)
October 21, 2026 21:58
Pedro Henrique Penna (ppenna)
disabled auto-merge
October 21, 2026 21:59
Pedro Henrique Penna (ppenna)
merged commit Oct 21, 2026
4bbee50
into
microsoft:dev
29 checks passed
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Sandbox launches accepted memory limits above the guest cgroup's unsigned 64-bit range and PID limits that become invalid after adding the init process. Oversized memory limits can wrap, while oversized PID limits stop guest boot.
Change
Validate both limits in
SandboxLaunchso CLI and library callers are refused values the guest cannot apply.Testing
cargo test --lib host::sandbox::tests::launch_rejects_limits_the_guest_cgroup_cannot_storefailed on the unfixed code with the oversized memory limit accepted, then passed after the validation was added.Regression test: tested and passed.
Fixes #733