Repository navigation
nvx-rs: rename the package to nvx - #650
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoOct 20, 2026
Merged
Conversation
The crate's package now has the name of its library, nvx, which is the name that it would take on a registry. Dependents declare it as nvx and enable its features as nvx/FEATURE; code keeps its nvx:: paths. The nvx-rs/ directory, the nvx-rs command-line interface, the nvx-rs CI job and check-nvx-rs action, and the digest domains keep their names. Update the dependency declarations and lockfiles of aci_edge_sandboxes, its model, and the runtime adapter; the runtime adapter's dependency-tree tests and the Python tests that name the package; the library's error message that names the crate; and the documentation that names the crate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fd6f22e8-0e12-4206-8f7b-b7090a940d00
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical rename is consistently reflected in consumers, lockfiles, tests, and documentation, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Renames the NVX mechanics package to nvx, matching its library name for future publication while preserving directory, CLI, and CI identifiers.
Changes:
- Updates package names, consumer dependencies, feature references, and lockfiles.
- Adjusts test assertions and the bundled-artifact error message.
- Updates documentation and records the breaking dependency-name change.
| File | Description |
|---|---|
| tests/runtime-adapter/tests/independent_build.rs | Updates package lookup and feature assertions. |
| tests/runtime-adapter/src/lib.rs | Updates crate names in comments. |
| tests/runtime-adapter/src/bin/runtime-adapter-host.rs | Updates the introductory comment. |
| tests/runtime-adapter/README.md | Documents the renamed dependency. |
| tests/runtime-adapter/Cargo.toml | Renames dependency and feature references. |
| tests/runtime-adapter/Cargo.lock | Updates package and dependency names. |
| scripts/test_nvx_tools.py | Updates manifest and notices assertions. |
| README.md | Updates the crate description. |
| nvx-rs/src/host/python/json.rs | Updates a crate reference in documentation. |
| nvx-rs/src/host/artifacts.rs | Updates error wording and its assertion. |
| nvx-rs/README.md | Explains package and library naming. |
| nvx-rs/Cargo.toml | Renames the package to nvx. |
| nvx-rs/Cargo.lock | Updates the package entry. |
| doc/usage.md | Updates the backend dependency description. |
| doc/project-structure.md | Distinguishes crate names from unchanged paths. |
| doc/contribute.md | Updates crate references in testing guidance. |
| doc/ci.md | Updates crate references, preserving job names. |
| doc/build.md | Updates the source-digest description. |
| aci_edge_sandboxes/README.md | Documents dependency naming and migration. |
| aci_edge_sandboxes/model/Cargo.toml | Renames the model’s dependency. |
| aci_edge_sandboxes/Cargo.toml | Updates dependency and feature references. |
| aci_edge_sandboxes/Cargo.lock | Updates package and dependency names. |
| aci_edge_sandboxes/build.rs | Updates bundle-forwarding comments. |
| .github/copilot-instructions.md | Updates crate names in guidance. |
| .github/actions/check-nvx-rs/action.yml | Updates the action description only. |
| .github/actions/check-aci-edge-sandboxes/action.yml | Updates the action description only. |
Review effort: Balanced
Enrique Saurez (esaurez)
approved these changes
Oct 20, 2026
Pedro Henrique Penna (ppenna)
deleted the
ppenna/rename-crate-nvx-20261020
branch
October 20, 2026 19:26
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Cargo package in
nvx-rs/fromnvx-rstonvx, the name of its library, so that the crate can be published under that name.aci_edge_sandboxes,aci_edge_sandboxes_model, and the runtime adapter declare the dependency asnvxand enable its features asnvx/FEATURE. Code keeps itsnvx::paths. In the three lockfiles, only the package entry's name changes.Unchanged: the
nvx-rs/directory, thenvx-rsCLI binary, thenvx-rsCI job and thecheck-nvx-rsaction,NVX_RS, the provenance file names, and the digest domains.Updated to the new name:
aci_edge_sandboxes/README.mdlists the rename under breaking changes, for crates that depend on the package directly.nvx-rs/Cargo.tomlandnvx-rs/Cargo.lockare inputs to thenvx-rssource digest and the Ubuntu converter input digest, so CI rebuilds those artifacts.Validation
All local checks ran on a Windows host.
On this branch, rebased on
dev:cargo fmt --check, Clippy with-D warnings, andcargo test --lockedfornvx(all features),aci_edge_sandboxes(workspace, all features), and the runtime adapter (protocol-only and host-only)--lockedresolution of all three lockfiles;cargo packageproducesnvx-0.1.0.cratepython -m unittest scripts/test_nvx_tools.py scripts/test_markdown_links.py, ruff, andscripts/check_markdown_links.pyBefore the rebase, these also passed:
test_guest_binaries.py,test_microvm_tests.py,test_development_release.py, andtest_adversarial.pyThese were not run locally, and CI covers them: the Linux-only musl guest-binary and guest-only adapter builds, the macOS and minimum-Rust-version checks, and the hypervisor jobs.