Skip to content

nvx-rs: rename the package to nvx - #650

Merged
Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
ppenna/rename-crate-nvx-20261020
Oct 20, 2026
Merged

Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
ppenna/rename-crate-nvx-20261020

Conversation

@ppenna

Copy link
Copy Markdown
Contributor

Summary

Renames the Cargo package in nvx-rs/ from nvx-rs to nvx, the name of its library, so that the crate can be published under that name.

  • aci_edge_sandboxes, aci_edge_sandboxes_model, and the runtime adapter declare the dependency as nvx and enable its features as nvx/FEATURE. Code keeps its nvx:: paths. In the three lockfiles, only the package entry's name changes.

  • Unchanged: the nvx-rs/ directory, the nvx-rs CLI binary, the nvx-rs CI job and the check-nvx-rs action, NVX_RS, the provenance file names, and the digest domains.

  • Updated to the new name:

    • the runtime adapter's dependency-tree tests
    • the two Python tests that name the package: the adapter's manifest line and the third-party notices' crate set
    • the library's "build the nvx crate with the bundled feature" error message
    • the documentation that names the crate

    aci_edge_sandboxes/README.md lists the rename under breaking changes, for crates that depend on the package directly.

nvx-rs/Cargo.toml and nvx-rs/Cargo.lock are inputs to the nvx-rs source digest and the Ubuntu converter input digest, so CI rebuilds those artifacts.

Validation

All local checks ran on a Windows host.

On this branch, rebased on dev:

  • cargo fmt --check, Clippy with -D warnings, and cargo test --locked for nvx (all features), aci_edge_sandboxes (workspace, all features), and the runtime adapter (protocol-only and host-only)
  • --locked resolution of all three lockfiles; cargo package produces nvx-0.1.0.crate
  • python -m unittest scripts/test_nvx_tools.py scripts/test_markdown_links.py, ruff, and scripts/check_markdown_links.py

Before the rebase, these also passed:

  • the default-feature Rust test and lint runs
  • test_guest_binaries.py, test_microvm_tests.py, test_development_release.py, and test_adversarial.py

These were not run locally, and CI covers them: the Linux-only musl guest-binary and guest-only adapter builds, the macOS and minimum-Rust-version checks, and the hypervisor jobs.

The crate's package now has the name of its library, nvx, which is the
name that it would take on a registry. Dependents declare it as nvx and
enable its features as nvx/FEATURE; code keeps its nvx:: paths.

The nvx-rs/ directory, the nvx-rs command-line interface, the nvx-rs CI
job and check-nvx-rs action, and the digest domains keep their names.

Update the dependency declarations and lockfiles of aci_edge_sandboxes,
its model, and the runtime adapter; the runtime adapter's dependency-tree
tests and the Python tests that name the package; the library's error
message that names the crate; and the documentation that names the crate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fd6f22e8-0e12-4206-8f7b-b7090a940d00
Copilot AI balanced review requested due to automatic review settings October 20, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The mechanical rename is consistently reflected in consumers, lockfiles, tests, and documentation, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Renames the NVX mechanics package to nvx, matching its library name for future publication while preserving directory, CLI, and CI identifiers.

Changes:

  • Updates package names, consumer dependencies, feature references, and lockfiles.
  • Adjusts test assertions and the bundled-artifact error message.
  • Updates documentation and records the breaking dependency-name change.
File Description
tests/​runtime-adapter/​tests/​independent_build.rs Updates package lookup and feature assertions.
tests/​runtime-adapter/​src/​lib.rs Updates crate names in comments.
tests/​runtime-adapter/​src/​bin/​runtime-adapter-host.rs Updates the introductory comment.
tests/​runtime-adapter/​README.md Documents the renamed dependency.
tests/​runtime-adapter/​Cargo.toml Renames dependency and feature references.
tests/​runtime-adapter/​Cargo.lock Updates package and dependency names.
scripts/​test_nvx_tools.py Updates manifest and notices assertions.
README.md Updates the crate description.
nvx-rs/​src/​host/​python/​json.rs Updates a crate reference in documentation.
nvx-rs/​src/​host/​artifacts.rs Updates error wording and its assertion.
nvx-rs/​README.md Explains package and library naming.
nvx-rs/​Cargo.toml Renames the package to nvx.
nvx-rs/​Cargo.lock Updates the package entry.
doc/​usage.md Updates the backend dependency description.
doc/​project-structure.md Distinguishes crate names from unchanged paths.
doc/​contribute.md Updates crate references in testing guidance.
doc/​ci.md Updates crate references, preserving job names.
doc/​build.md Updates the source-digest description.
aci_edge_sandboxes/​README.md Documents dependency naming and migration.
aci_edge_sandboxes/​model/​Cargo.toml Renames the model’s dependency.
aci_edge_sandboxes/​Cargo.toml Updates dependency and feature references.
aci_edge_sandboxes/​Cargo.lock Updates package and dependency names.
aci_edge_sandboxes/​build.rs Updates bundle-forwarding comments.
.github/​copilot-instructions.md Updates crate names in guidance.
.github/​actions/​check-nvx-rs/​action.yml Updates the action description only.
.github/​actions/​check-aci-edge-sandboxes/​action.yml Updates the action description only.

Review effort: Balanced

@ppenna
Pedro Henrique Penna (ppenna) merged commit fb146f2 into dev Oct 20, 2026
33 checks passed
@ppenna
Pedro Henrique Penna (ppenna) deleted the ppenna/rename-crate-nvx-20261020 branch October 20, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants