Repository navigation
doctor check_rate: don't fail H4 when host clocksource is unreadable - #509
Merged
Pedro Henrique Penna (ppenna) merged 5 commits intoOct 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused error handling matches H4’s contract and is adequately covered by regression tests.
0 open findings
What changed in this PR
Prevents optional Linux clocksource evidence from incorrectly failing the H4 rate check.
Changes:
- Records clocksource read errors as unknown evidence while continuing measurements.
- Adds regression coverage for passing and failing measurement outcomes.
| File | Description |
|---|---|
scripts/nvx_tools/doctor.py |
Handles clocksource read failures without affecting H4 verdicts. |
scripts/test_time_abi.py |
Tests unreadable clocksource behavior and measurement-based verdicts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Pedro Henrique Penna (@ppenna) Can you please add me to the contributor list so that changes can be merged directly |
Pedro Henrique Penna (ppenna)
merged commit Oct 12, 2026
b1dadb7
into
microsoft:dev
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507
The host clocksource is recorded as evidence only, so an unreadable sysfs file must not fail the H4 rate check.
check_ratenow catches OSError fromhost_clocksource(), records it explicitly asunknown (<error>), and still runs the TSC rate/stability measurements below — the verdict depends on the measurements alone. Regression test added.