Repository navigation
[WSLC] Bump WSLc SDK to 3.0.3 - #1550
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: df93958a-1870-40ab-8460-9d6e6ee75429
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The probe can unload the SDK while callback threads remain active, risking an access violation during teardown.
1 open issue
What changed in this PR
Updates the WSLc SDK to 3.0.3 as groundwork for #1258. MXC stdin forwarding remains unchanged.
Changes:
- Updates the SDK pin, generated bindings, and required DLL exports.
- Adds an ignored stdin-handle probe.
- Updates runtime prerequisites and binding-generation guidance.
| File | Description |
|---|---|
| src/mxc-sdk/tests/wslc_stdin_handle_probe.rs | Adds handle and stdin round-trip checks. |
| src/mxc-sdk/src/lib.rs | Clarifies MXC’s stdin limitation. |
| src/mxc-sdk/src/backends/wslc/common/wslcsdk_sys.rs | Adds generated process-flag bindings. |
| src/mxc-sdk/src/backends/wslc/common/wslc_bindings.rs | Requires the new process-flags export. |
| src/mxc-sdk/src/backends/wslc/common/wsl_container_runner.rs | Updates prerequisite-message assertions. |
| src/mxc-sdk/src/backends/wslc/common/sdk_init.rs | Updates WSL installation guidance. |
| src/mxc-sdk/src/backends/wslc/common/sandbox.rs | Corrects stdin documentation. |
| src/mxc-sdk/build/wslc_common/README.md | Updates package and regeneration guidance. |
| src/mxc-sdk/build/build_wslc_common.rs | Pins SDK 3.0.3 and its checksum. |
| scripts/generate-wslc-bindings.ps1 | Registers process flags as bitflags. |
| scripts/ci/prepare-windows-host.ps1 | Clarifies the existing update-channel comment. |
| docs/development/build-and-test/wslc-sdk-bindings.md | Updates build and probe instructions. |
| docs/backends/wslc/wslc-state-aware.md | Updates SDK version and stdin wording. |
| docs/backends/wslc/wsl-container-getting-started.md | Raises prerequisites and corrects stdin guidance. |
Review effort: Balanced
| // SAFETY: COM is initialised on this thread for the whole test, and every | ||
| // guard outlives the SDK calls made against the handle it owns. | ||
| unsafe { | ||
| let sdk = load_sdk_checked(&mut logger).expect("WSLc runtime unavailable"); |
Gudge (MGudgin)
approved these changes
Oct 21, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📖 Description
Updates the pinned WSLc SDK from 2.9.9 to 3.0.3. 3.0.3 adds
WslcSetProcessSettingsFlagswithWSLC_PROCESS_FLAG_STDIN, which lets a caller open a container process's stdin. MXC does not forward stdin yet; that comes in the next PR.🔗 References
Fixes #1585.
Part of #1258. Upstream: microsoft/WSL#41698.
🔍 Validation
cargo fmt --all -- --check: passedcargo clippy --workspace --all-targets -- -D warnings: passedcargo clippy -p mxc-sdk --features wslc --all-targets -- -D warnings: passedcargo test --workspace: 4257 passed, 0 failedcargo test -p mxc-sdk --features wslc --lib wslc::common: 360 passedcargo test -p mxc-sdk --features wslc --test wslc_stdin_handle_probe -- --ignored: passed. Without the flag, stdin returnsE_INVALIDARG. With it, stdin returnsS_OK, including when callbacks are registered, and data written to stdin comes back throughcat. Against the 2.9.9 DLL, loading fails as expected.tests\scripts\run_wslc_all_tests.ps1(x64 release, WSL 3.0.4): 40/40 before and after. The state-aware suite inside it is 123/123 before and after.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow