Repository navigation
Fix Node SDK proc scan process-exit race - #1295
Merged
Merged
Conversation
Use the shared process-disappearance predicate while enumerating /proc so a process exiting between directory enumeration and status-file reads does not fail the detached-anchor test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b0285d2-142d-4d79-912e-7e8d22287db2
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly resolves the documented race without suppressing unrelated errors.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Node SDK Linux test helper to tolerate expected /proc process-exit races.
Changes:
- Reuses
isProcessGoneErrorto handle bothENOENTandESRCH. - Continues rethrowing unexpected filesystem errors.
| File | Description |
|---|---|
sdk/node/tests/unit/platform.test.ts |
Handles both expected process-disappearance errors during zombie scans. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gudge (MGudgin)
pushed a commit
that referenced
this pull request
Sep 27, 2026
Restore the proc-scan behavior owned by PR #1295 so this branch remains focused on worker readiness synchronization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b0285d2-142d-4d79-912e-7e8d22287db2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat both
ENOENTandESRCHas expected process-disappearance errors whilethe Node SDK detached-anchor test scans
/proc. This reuses the existingisProcessGoneErrorhelper and continues to surface unexpected filesystemerrors.
Resolves #1293
Tests
npm run build:test-unitnode --test --test-name-pattern="reaps the detached anchor after repeated probes" dist-tests\tests\unit\platform.test.jsMicrosoft Reviewers: Open in CodeFlow