Skip to content

[WSLC] Harden exact contract infrastructure - #1189

Merged
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups
Sep 22, 2026
Merged

Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups

Conversation

@MGudgin

@MGudgin Gudge (MGudgin) commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

📖 Description

Hardens exact-contract infrastructure with focused cleanup that reduces
duplicated conformance tests and makes registry-driven code-generation and
backend-name checks fail closed while preserving published v0.9 WSLC roots.

Details

  • Internalize normalization DTOs as non-deserializable implementation types.
  • Share v0.9 and v0.10 exact conformance suites.
  • Centralize artifact and request-root metadata in the Rust registry.
  • Keep WslcProvisionRequest registered in the published v0.9 contract.
  • Drive fixture diagnostics from registered roots and reject inconsistent
    renderability metadata without panicking.
  • Validate backend names through the parser and simplify probe checks.
  • Document exact-contract authority and the registry-owned contributor flow.

Tests

  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --exclude wxc_e2e_tests
  • Node build, unit tests, and integration type-check on the unchanged parent
    Node tree
  • 82 versioning tests and all exact codegen, parity, and config gates
  • 363 repository configs validated against five registered exact schemas
Microsoft Reviewers: Open in CodeFlow

@MGudgin
Gudge (MGudgin) requested a review from a team as a code owner September 16, 2026 22:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Gudge (MGudgin) pushed a commit that referenced this pull request Sep 18, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
@MGudgin
Gudge (MGudgin) requested review from a team and a balanced review from Copilot September 18, 2026 21:19
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from 1d76e9c to b754171 Compare September 18, 2026 21:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The registry, parser, tests, scripts, and documentation remain consistent with no unresolved correctness issues found.

Review effort: Balanced
Findings: None

What changed in this PR

Hardens exact-contract generation, parsing, and conformance testing while preserving published v0.9 WSLC request roots.

Changes:

  • Makes normalization DTOs private and non-deserializable.
  • Centralizes artifact/request-root metadata in the contract registry.
  • Shares v0.9/v0.10 conformance suites and strengthens registry-driven validation.
File Description
src/​tools/​mxc_schema_gen/​src/​main.rs Emits and validates registry metadata.
src/​core/​wxc_common/​src/​wire.rs Internalizes normalization DTOs and backend-name parsing.
src/​core/​wxc_common/​src/​splice.rs Uses explicit containment-name parsing.
src/​core/​wxc_common/​src/​models.rs Updates containment normalization documentation.
src/​core/​wxc_common/​src/​lib.rs Makes wire crate-private.
src/​core/​wxc_common/​src/​config_contract_adapters/​v0_9/​state_aware_tests/​common.rs Constructs DTO defaults directly.
src/​core/​wxc_common/​src/​config_contract_adapters/​dev/​state_aware_tests/​common.rs Constructs DTO defaults directly.
src/​core/​mxc_engine/​src/​probe.rs Validates canonical backend names.
src/​core/​mxc_engine/​src/​policy.rs Tests emitted JSON against the exact contract.
src/​core/​mxc_engine/​src/​platform.rs Uses canonical runtime backend names.
src/​core/​mxc_config_contract/​tests/​v0_9_0_alpha/​state_aware/​common.rs Re-exports v0.9 request types.
src/​core/​mxc_config_contract/​tests/​v0_9_0_alpha/​state_aware.rs Uses shared lifecycle tests.
src/​core/​mxc_config_contract/​tests/​v0_9_0_alpha/​common.rs Exposes the v0.9 one-shot type to shared tests.
src/​core/​mxc_config_contract/​tests/​v0_9_0_alpha.rs Configures shared v0.9 suites.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware/​stop.rs Removes duplicated stop tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware/​start.rs Removes duplicated start tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware/​exec.rs Removes duplicated exec tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware/​deprovision.rs Removes duplicated deprovision tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware/​common.rs Re-exports development request types.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​state_aware.rs Uses shared lifecycle tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​one_shot.rs Removes duplicated one-shot tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​common.rs Exposes the development one-shot type.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha/​annotations.rs Removes duplicated annotation tests.
src/​core/​mxc_config_contract/​tests/​v0_10_0_alpha.rs Configures shared v0.10 suites.
src/​core/​mxc_config_contract/​tests/​support/​state_aware/​stop.rs Parameterizes shared stop tests.
src/​core/​mxc_config_contract/​tests/​support/​state_aware/​start.rs Parameterizes shared start tests.
src/​core/​mxc_config_contract/​tests/​support/​state_aware/​exec.rs Parameterizes shared exec tests.
src/​core/​mxc_config_contract/​tests/​support/​state_aware/​deprovision.rs Parameterizes shared deprovision tests.
src/​core/​mxc_config_contract/​tests/​support/​one_shot.rs Parameterizes shared one-shot tests.
src/​core/​mxc_config_contract/​tests/​support/​exact.rs Adds version-aware test helpers.
src/​core/​mxc_config_contract/​tests/​support/​annotations.rs Parameterizes annotation tests.
src/​core/​mxc_config_contract/​src/​registry.rs Adds artifact and request-root metadata.
src/​core/​mxc_config_contract/​src/​lib.rs Exports request-root metadata.
src/​backends/​isolation_session/​common/​src/​state_aware.rs Removes obsolete wire deserialization test.
scripts/​versioning/​tests/​check-contract-codegen.test.js Tests registry-driven validation.
scripts/​versioning/​check-schema-versions.js Checks canonical registry roots and renderability.
scripts/​versioning/​check-contract-codegen.js Drives codegen and fixtures from registry metadata.
docs/​versioning.md Documents exact-contract authority and normalization.
docs/​schema-codegen.md Documents registry-owned codegen workflow.
docs/​backend-support-probe-api-plan.md Updates canonical backend-name source.
docs/​architecture.md Documents exact parsing and private normalization.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 18, 2026 21:46
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from b754171 to c9b9351 Compare September 18, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The registry, parser normalization, shared tests, validation scripts, and documentation are consistent with the registered contracts.

Review effort: Balanced
Findings: None

Copilot AI review requested due to automatic review settings September 18, 2026 21:58
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from c9b9351 to 5667b9a Compare September 18, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Repository contributor guidance still describes the rolling parser architecture that this change removes.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)

Comment thread docs/architecture.md Resolved
Copilot AI review requested due to automatic review settings September 18, 2026 22:05
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from 5667b9a to c4143ab Compare September 18, 2026 22:05
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from c4143ab to 794ef19 Compare September 18, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The refactor consistently preserves exact-contract authority, validates registry metadata fail-closed, and retains coverage through shared version-specific suites.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI review requested due to automatic review settings September 18, 2026 22:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

It changes published-contract authority, parsing boundaries, and cross-language generation gates, warranting final human review despite strong coverage.

Review effort: Balanced
Findings: None

@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from ccba740 to a8ffc59 Compare September 21, 2026 22:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The registry, parser, shared tests, validation scripts, and documentation remain consistent with no unresolved correctness issues found.

Review effort: Balanced
Findings: None

Base automatically changed from user/gudge/version_specific_config_parsers_phase13_wslc_graduation to main September 22, 2026 00:56
This PR hardens exact-contract infrastructure with focused cleanup that
reduces duplicated conformance tests and makes registry-driven code-generation
and backend-name checks fail closed while preserving published v0.9 WSLC roots.

Details

* Internalize normalization DTOs as non-deserializable implementation types.
* Share v0.9 and v0.10 exact conformance suites.
* Centralize artifact and request-root metadata in the Rust registry.
* Keep WslcProvisionRequest registered in the published v0.9 contract.
* Drive fixture diagnostics from registered roots and reject inconsistent
  renderability metadata without panicking.
* Validate backend names through the parser and simplify probe checks.
* Document exact-contract authority and the registry-owned contributor flow.

Tests

* `cargo fmt --all -- --check`, `cargo check --workspace --all-targets`,
  and all-feature workspace Clippy passed.
* Workspace tests passed with `wxc_e2e_tests` excluded from the host-neutral run.
* Node build, unit tests, and integration type-check passed on the unchanged
  parent Node tree.
* All 82 versioning tests and exact codegen/parity/config gates passed; 363
  repository configs validated against five registered exact schemas.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Copilot AI review requested due to automatic review settings September 22, 2026 01:16
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch from a8ffc59 to dc73749 Compare September 22, 2026 01:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

It changes cross-cutting parser and published-contract infrastructure across Rust, JavaScript validation, and shared conformance suites.

Review effort: Balanced
Findings: None

@MGudgin
Gudge (MGudgin) merged commit 8ac67da into main Sep 22, 2026
29 checks passed
@MGudgin
Gudge (MGudgin) deleted the user/gudge/version_specific_config_parsers_phase13_wslc_graduation_followups branch September 22, 2026 13:46
Gudge (MGudgin) pushed a commit that referenced this pull request Sep 22, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Sep 24, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Sep 27, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Sep 28, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Oct 3, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Oct 6, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Oct 12, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Gudge (MGudgin) pushed a commit that referenced this pull request Oct 29, 2026
This PR updates the version-aware execution plans with the finalized non-WSLC
stack and the remaining WSLC-inclusive rebuild work.

Details

* Record the final #1184 through #1186 tips, topology, validation, and review
  status.
* Document the #1187 through #1189 base and topology problems and the required
  one-commit restack sequence.
* List the semantic and code-generation fixes that must be ported while
  preserving stable v0.9 WSLC behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 075defa1-7450-47ec-a6d8-953c69d509ee
Generated-with: gpt-5.6-sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants