Repository navigation
Complete the v0.9 directional networking cutover - #1145
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
7e98573 to
5b74c0d
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The C# state-aware converter silently drops the removed enforcementMode field, and several updated documentation passages are incorrect or incomplete.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (5)
What changed in this PR
Completes the v0.9 transition to directional networking across contracts, backends, SDKs, tests, generated types, and documentation while retaining legacy syntax for published contracts.
Changes:
- Removes legacy v0.9 network fields and moves proxies to
runtimeConfig.networkProxy. - Updates WSLC, NanVix, IsolationSession, SDK, FFI, and fixture behavior.
- Adds migration guards, contract coverage, and documentation.
| File | Description |
|---|---|
tests/scripts/run_wslc_proxy_test.ps1 |
Updates proxy terminology. |
tests/scripts/run_isolation_session_resize_smoke.ps1 |
Uses directional acknowledgment. |
tests/scripts/run_hyperlight_network_migration_test.ps1 |
Adds migration rejection tests. |
tests/policy/state-aware-wslc-provision.json |
Updates provision policy. |
tests/policy/state-aware-wslc-exec.json |
Moves exec proxy configuration. |
tests/playground/src/renderer/app.ts |
Updates raw backend networking. |
tests/examples/wslc_hello_world.json |
Migrates WSLC example. |
tests/configs/wslc_timeout.json |
Migrates isolated networking. |
tests/configs/wslc_tar_import_rootfs.json |
Migrates isolated networking. |
tests/configs/wslc_tar_import_docker_save.json |
Migrates isolated networking. |
tests/configs/wslc_stderr.json |
Migrates isolated networking. |
tests/configs/wslc_state_aware_provision.json |
Migrates provision networking. |
tests/configs/wslc_state_aware_provision_with_filesystem.json |
Migrates provision networking. |
tests/configs/wslc_state_aware_provision_rejected_proxy.json |
Moves rejected proxy input. |
tests/configs/wslc_state_aware_provision_rejected_hosts.json |
Uses directional rule rejection. |
tests/configs/wslc_state_aware_provision_rejected_denied.json |
Migrates isolated networking. |
tests/configs/wslc_state_aware_provision_bridged.json |
Uses all-allow posture. |
tests/configs/wslc_state_aware_exec_proxy.json |
Moves runtime proxy configuration. |
tests/configs/wslc_readonly_mount.json |
Migrates isolated networking. |
tests/configs/wslc_python_stdlib.json |
Migrates isolated networking. |
tests/configs/wslc_python_hello.json |
Migrates isolated networking. |
tests/configs/wslc_port_mapping_tcp.json |
Uses unrestricted posture. |
tests/configs/wslc_port_mapping_multiple.json |
Uses unrestricted posture. |
tests/configs/wslc_network_proxy.json |
Migrates proxy configuration. |
tests/configs/wslc_network_isolated.json |
Uses directional denial. |
tests/configs/wslc_most_specific_denied_parent.json |
Uses unrestricted posture. |
tests/configs/wslc_large_output.json |
Migrates isolated networking. |
tests/configs/wslc_filesystem.json |
Uses unrestricted posture. |
tests/configs/wslc_filesystem_object.json |
Uses unrestricted posture. |
tests/configs/wslc_exit_code.json |
Migrates isolated networking. |
tests/configs/wslc_env_vars.json |
Migrates isolated networking. |
tests/configs/wslc_destroy_on_exit_true.json |
Migrates isolated networking. |
tests/configs/wslc_destroy_on_exit_false_rejected.json |
Migrates isolated networking. |
tests/configs/wslc_denied_masking.json |
Uses unrestricted posture. |
tests/configs/wslc_denied_dotdot_alias.json |
Uses unrestricted posture. |
tests/configs/wslc_custom_registry.json |
Uses unrestricted posture. |
tests/configs/wslc_custom_registry_quay.json |
Uses unrestricted posture. |
tests/configs/wslc_custom_registry_ghcr.json |
Uses unrestricted posture. |
tests/configs/microvm_network.json |
Uses unrestricted directional policy. |
tests/configs/microvm_network_linux.json |
Uses unrestricted directional policy. |
tests/configs/isolation_session_timeout.json |
Migrates required acknowledgment. |
tests/configs/isolation_session_streaming_smoke.json |
Migrates required acknowledgment. |
tests/configs/isolation_session_stdout_stderr_interleaved.json |
Migrates required acknowledgment. |
tests/configs/isolation_session_stderr.json |
Migrates required acknowledgment. |
tests/configs/isolation_session_state_aware_provision.json |
Migrates provision acknowledgment. |
tests/configs/isolation_session_state_aware_provision_with_filesystem.json |
Adds directional acknowledgment. |
tests/configs/isolation_session_state_aware_provision_rejected_ui.json |
Migrates rejection fixture. |
tests/configs/isolation_session_state_aware_provision_rejected_network.json |
Uses restrictive directional input. |
tests/configs/isolation_session_state_aware_provision_rejected_denied.json |
Adds required acknowledgment. |
tests/configs/isolation_session_state_aware_provision_appid.json |
Migrates AppId fixture. |
tests/configs/isolation_session_state_aware_provision_appid_too_long.json |
Migrates invalid AppId fixture. |
tests/configs/isolation_session_state_aware_provision_appid_empty.json |
Migrates empty AppId fixture. |
tests/configs/isolation_session_state_aware_provision_appid_control.json |
Migrates control-character fixture. |
tests/configs/isolation_session_powershell_interactive.json |
Migrates interactive fixture. |
tests/configs/isolation_session_one_shot_ui_rejected.json |
Migrates UI rejection fixture. |
tests/configs/isolation_session_one_shot_stray_config_rejected.json |
Migrates stray-config fixture. |
tests/configs/isolation_session_one_shot_network_rejected.json |
Uses directional denial. |
tests/configs/isolation_session_one_shot_network_rejected_no_local.json |
Uses mixed directional posture. |
tests/configs/isolation_session_one_shot_network_rejected_hosts.json |
Uses CIDR-rule rejection. |
tests/configs/isolation_session_one_shot_lifecycle_rejected.json |
Migrates lifecycle fixture. |
tests/configs/isolation_session_exit42.json |
Migrates exit-code fixture. |
tests/configs/isolation_session_configid_rejected.json |
Migrates configuration rejection. |
tests/configs/isolation_session_concurrent_D.json |
Migrates concurrency fixture. |
tests/configs/isolation_session_concurrent_C.json |
Migrates concurrency fixture. |
tests/configs/isolation_session_concurrent_B.json |
Migrates concurrency fixture. |
tests/configs/isolation_session_concurrent_A.json |
Migrates concurrency fixture. |
tests/configs/hyperlight_networking.json |
Marks intentional migration rejection. |
tests/configs/hyperlight_networking_blocked.json |
Marks intentional migration rejection. |
src/testing/wxc_e2e_tests/tests/e2e_isolation_session_policy.rs |
Updates native policy tests. |
src/ffi/mxc_ffi/src/state_aware.rs |
Updates FFI lifecycle tests. |
src/ffi/mxc_ffi/src/request.rs |
Preserves legacy migration diagnostics. |
src/ffi/mxc_ffi/src/lib.rs |
Adds legacy-field rejection tests. |
src/ffi/mxc_ffi/examples/attached_console_ffi.rs |
Updates example acknowledgment. |
src/core/wxc_common/src/validator.rs |
Clarifies proxy capability semantics. |
src/core/wxc_common/src/state_aware_binding_tests.rs |
Updates binding fixtures. |
src/core/wxc_common/src/policy_identity.rs |
Updates policy-hash inputs. |
src/core/wxc_common/src/network_parser.rs |
Supports WSLC-routable proxies. |
src/core/wxc_common/src/config_deserialize.rs |
Exposes structural error paths. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware.rs |
Adapts runtime proxy fields. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/provision.rs |
Updates provision adapter tests. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/exec.rs |
Updates exec adapter tests. |
src/core/wxc_common/src/config_contract_adapters/dev/one_shot.rs |
Reuses runtime conversion. |
src/core/wxc_common/src/config_contract_adapters/dev/common.rs |
Removes legacy v0.9 conversion. |
src/core/mxc-sdk/tests/state_aware.rs |
Updates state-aware SDK tests. |
src/core/mxc-sdk/tests/isolation_session.rs |
Updates IsolationSession tests. |
src/core/mxc-sdk/README.md |
Documents directional provisioning. |
src/core/mxc-sdk/examples/sta_probe.rs |
Updates provisioning examples. |
src/core/mxc-sdk/examples/isolation_session_console.rs |
Updates console example. |
src/core/mxc_engine/src/state_aware.rs |
Updates engine test inputs. |
src/core/mxc_engine/src/policy/exact/v0_9.rs |
Emits directional-only contracts. |
src/core/mxc_config_contract/tests/version_boundaries/state_aware.rs |
Updates version-boundary cases. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/state_aware/provision/wslc.rs |
Tests directional provision. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/state_aware/exec.rs |
Tests runtime proxy input. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/request.rs |
Updates request selection test. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/optional_fields.rs |
Updates optional arrays. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/network.rs |
Expands cutover coverage. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/wslc_provision/valid/directional_network.json |
Adds valid WSLC fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/wslc_provision/invalid/runtime_proxy.json |
Adds invalid provision proxy. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/one_shot/valid/proxy_url.json |
Migrates proxy fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/one_shot/valid/complete.json |
Migrates complete fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/one_shot/invalid/proxy_localhost.json |
Adds removed-proxy fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/one_shot/invalid/proxy_builtin.json |
Adds removed-proxy fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/one_shot/invalid/isolation_session_legacy_network.json |
Adds legacy rejection fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/isolation_session_provision/valid/minimal.json |
Migrates minimal fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/exec/valid/runtime_proxy.json |
Adds valid exec proxy fixture. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures/exec/invalid/legacy_proxy.json |
Adds legacy proxy rejection. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/fixtures.rs |
Validates dispatched fixtures. |
src/core/mxc_config_contract/tests/v0_9_0_alpha/enums.rs |
Tests removed enums. |
src/core/mxc_config_contract/src/dev/state_aware/provision/mod.rs |
Removes legacy exports. |
src/core/mxc_config_contract/src/dev/state_aware/mod.rs |
Removes legacy exports. |
src/core/mxc_config_contract/src/dev/state_aware/exec.rs |
Adds runtime configuration. |
src/core/mxc_config_contract/src/dev/stable.rs |
Updates proxy documentation. |
src/core/mxc_config_contract/src/dev/schema.rs |
Adds schema cutover guards. |
src/core/mxc_config_contract/src/dev/request.rs |
Extends parse error modeling. |
src/core/mxc_config_contract/src/dev/network.rs |
Removes legacy v0.9 fields. |
src/core/mxc_config_contract/src/dev/mod.rs |
Updates contract exports. |
src/backends/wslc/common/src/wsl_container_runner.rs |
Enforces directional WSLC policy. |
src/backends/isolation_session/common/src/state_aware.rs |
Updates directional test policies. |
src/backends/isolation_session/common/src/one_shot.rs |
Updates directional test policies. |
sdk/node/tests/unit/wire-conformance-state-aware.test.ts |
Checks exact generated types. |
sdk/node/tests/unit/state-aware.test.ts |
Updates lifecycle envelopes. |
sdk/node/tests/unit/state-aware-types.test.ts |
Updates public type tests. |
sdk/node/tests/integration/wslc-e2e.test.ts |
Migrates integration policies. |
sdk/node/src/types.ts |
Adds directional network types. |
sdk/node/src/state-aware.ts |
Updates lifecycle documentation. |
sdk/node/src/state-aware-helper.ts |
Validates and lifts new fields. |
sdk/node/src/sandbox.ts |
Enforces versioned authoring. |
sdk/node/src/index.ts |
Exports and documents new types. |
sdk/node/src/generated/v0_9_0_alpha/wire.ts |
Regenerates exact wire types. |
sdk/node/README.md |
Documents v0.9 cutover. |
sdk/dotnet/README.md |
Documents directional lifecycle policy. |
sdk/dotnet/Microsoft.Mxc.Sdk/StateAwareNetworkPolicyJsonConverter.cs |
Preserves legacy field presence. |
sdk/dotnet/Microsoft.Mxc.Sdk/SchemaVersions.cs |
Adds exact-version helpers. |
sdk/dotnet/Microsoft.Mxc.Sdk/SandboxPolicy.cs |
Tracks authored legacy fields. |
sdk/dotnet/Microsoft.Mxc.Sdk/MxcSandbox.cs |
Applies version-aware serialization. |
sdk/dotnet/Microsoft.Mxc.Sdk/MxcLifecycle.cs |
Validates directional lifecycle options. |
sdk/dotnet/Microsoft.Mxc.Sdk.Sample/Program.cs |
Updates sample provisioning. |
sdk/dotnet/Microsoft.Mxc.Sdk.ConsoleDriver/Program.cs |
Updates console provisioning. |
scripts/versioning/tests/check-contract-codegen.test.js |
Tests recursive schema guard. |
scripts/versioning/config-validation-exemptions.json |
Registers intentional invalid fixtures. |
scripts/check-dotnet-api-parity.js |
Ignores internal presence metadata. |
docs/wsl/wslc-state-aware.md |
Documents directional WSLC policy. |
docs/versioning.md |
Documents the contract cutover. |
docs/state-aware-lifecycle/mxc-state-aware-sandbox-api-overview.md |
Updates lifecycle examples. |
docs/seatbelt/seatbelt-backend.md |
Documents v0.9 syntax. |
docs/schema.md |
Updates schema guidance. |
docs/schema-codegen.md |
Documents recursive guards. |
docs/process-container/guide.md |
Documents directional networking. |
docs/nanvix-microvm/nanvix.md |
Documents coherent NanVix modes. |
docs/lxc-support/lxc-backend.md |
Documents v0.9 migration. |
docs/isolation-session/state-aware-typescript.md |
Updates TypeScript guidance. |
docs/isolation-session/state-aware-rust.md |
Updates Rust lifecycle guidance. |
docs/isolation-session/oneshot.md |
Updates one-shot policy guidance. |
docs/bwrap-support/bubblewrap-backend.md |
Documents v0.9 syntax. |
.github/workflows/microvm-e2e.yml |
Broadens MicroVM test selection. |
.github/workflows/hyperlight-e2e.yml |
Adds migration rejection validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5b74c0d to
e60adec
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The exact runtime parser and generated schema disagree on whether one-shot IsolationSession requests may omit network.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
e60adec to
7c7bf12
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several changed comments and public documentation contradict the implemented network behavior and API contract.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (7)
Preserve enforcementMode as a removed legacy field Keep exact parsing aligned with the one-shot schema Describe Hyperlight's actual default-deny behavior · New Remove the duplicated phrase Correct the contradictory IsolationSession summary Show the actual absent provision config Complete the truncated schema paragraph
7c7bf12 to
c46ab59
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Rust one-shot tests omit the now-required network acknowledgment, Node integration callers still use rejected legacy fields, and SDK documentation contains stale examples.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 2
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (4)
Resolved findings (7)
Describe Hyperlight's actual default-deny behavior Keep exact parsing aligned with the one-shot schema Remove the duplicated phrase Correct the contradictory IsolationSession summary Show the actual absent provision config Complete the truncated schema paragraph Preserve enforcementMode as a removed legacy field
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The new Node WSLC README examples omit the mandatory experimental option and fail when copied.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
Resolved findings (2)
Previously missed findings (1)
In code that hasn't changed since last review

Pass the required experimental option when provisioning WSLC

sdk/node/README.md:391
This sample omits the required { experimental: true } option, so copying it reaches the CLI without --experimental and provisioning is rejected before the directional policy is used. Pass the opts object defined above as the third argument, consistent with the requirement at line 342.
This issue also appears on line 400 of the same file.
70c3574 to
a6176ac
Compare
a6176ac to
756ada8
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cross-language contract and backend cutover is broad, and native Unix plus live enforcement acceptance remains outstanding.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
756ada8 to
c5bb3d8
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The C# state-aware converter silently normalizes explicit null directional sections into an accepted empty WSLC policy.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (1)
c5bb3d8 to
eca9e59
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Node SDK still rejects all MicroVM networking, preventing callers from authoring the directional modes now supported by NanVix.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (2)
Resolved findings (1)
This PR changes the exact v0.9 contract to directional-only networking and migrates backend enforcement, SDK authoring, generated artifacts, and the request corpus together. Published v0.6, v0.7, and v0.8 contracts retain their existing syntax and compatibility behavior. Details * Remove legacy network fields from every v0.9 root and move cooperative proxies to runtimeConfig.networkProxy. * Express IsolationSession's unrestricted posture through directional egress, ingress, and host-loopback allow defaults on JSON and typed request paths. * Preserve removed C# state-aware inputs so validation returns actionable migration errors instead of silently dropping policy. * Update Node integration probes, Rust and C# tests, and SDK examples to author the final directional network shape. * Enforce truthful isolated or explicitly unrestricted WSLC and NanVix modes, rejecting unsupported directional filtering instead of approximating it. * Keep migration diagnostics backend- and phase-aware and preserve strict invalid-fixture routing. * Update generated artifacts, fixtures, examples, documentation, corpus inventory, migration diagnostics, and CI coverage. Tests * cargo fmt --all -- --check * cargo check --workspace --all-targets * cargo clippy --workspace --all-targets -- -D warnings * cargo build -p wxc --features isolation_session,wslc,microvm * cargo test --workspace * cargo test -p mxc-sdk --features isolation_session --test isolation_session * npm run build && npm test * npm run build (sdk/node/tests/integration) * dotnet test --solution Microsoft.Mxc.Sdk.slnx * Version, schema, codegen, SDK-type, config-corpus, C# error-code, and C# bindings gates passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 12c83c82-04f2-4bca-b3e1-5bbe7b279935 Generated-with: gpt-5.6-sol
eca9e59 to
c3cba73
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cross-language contract and backend cutover is broad, and native Unix plus live backend enforcement acceptance remains outstanding.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.


This PR changes the exact v0.9 contract to directional-only networking and
migrates backend enforcement, SDK authoring, generated artifacts, and the
request corpus together. Published v0.6, v0.7, and v0.8 contracts retain their
existing syntax and compatibility behavior.
Details
to
runtimeConfig.networkProxy, and require the explicit IsolationSessionunrestricted-network acknowledgment.
translating published legacy contracts into the canonical runtime model.
rejecting unsupported directional filtering instead of approximating it.
artifacts, migration diagnostics, documentation, and CI coverage.
model only as a test and compatibility reference.
Tests
cargo fmt --all -- --checkcargo check --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningswxc-exec.exewithisolation_session,wslc,microvm, the Windows E2E targetpassed 6 tests with 14 ignored; the IsolationSession policy target passed
4 tests.
passed. The versioning suite passed 71 tests, and 349 configs validated
against four exact schemas with 11 intentional negative exemptions.
remain outstanding
Microsoft Reviewers: Open in CodeFlow