Skip to content

[Part 9] Remove RetryPolicyOptions from tools - #3414

Merged
Alan Zimmer (alzimmermsft) merged 1 commit into
mainfrom
RemoveRetryPolicyOptionsPart9
Aug 28, 2026
Merged

[Part 9] Remove RetryPolicyOptions from tools#3414
Alan Zimmer (alzimmermsft) merged 1 commit into
mainfrom
RemoveRetryPolicyOptionsPart9

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Removed custom retry policy options from Virtual Desktop and Workbooks tools.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes RetryPolicyOptions from the Workbooks and Virtual Desktop tool contracts (options, command-to-service calls, and service interfaces), aligning these tools with Azure SDK retry defaults and making the removal explicit as a breaking change.

Changes:

  • Removed RetryPolicyOptions (--retry-*) from Workbooks and Virtual Desktop option models and command/service method signatures.
  • Updated unit tests to match the new service signatures and removed tests asserting retry options were passed through.
  • Added a changelog entry documenting the breaking change.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/UpdateWorkbooksCommandTests.cs Removes retry-related expectations and a retry-options test case.
tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/ShowWorkbooksCommandTests.cs Updates mocks to reflect removal of retry parameters.
tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/ListWorkbooksCommandTests.cs Updates mocks to reflect removal of retry parameters.
tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/DeleteWorkbooksCommandTests.cs Updates mocks and removes retry-options test case.
tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/CreateWorkbooksCommandTests.cs Updates mocks and removes retry-options test case.
tools/Azure.Mcp.Tools.Workbooks/src/Services/WorkbooksService.cs Removes retry policy parameters and uses AzureService defaults.
tools/Azure.Mcp.Tools.Workbooks/src/Services/IWorkbooksService.cs Removes retry policy from the public service contract.
tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/UpdateWorkbooksOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/ShowWorkbooksOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/ListWorkbooksOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/DeleteWorkbookOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/CreateWorkbookOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/UpdateWorkbooksCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/ShowWorkbooksCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/ListWorkbooksCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/DeleteWorkbooksCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/CreateWorkbooksCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/SessionHost/SessionHostUserSessionListCommandTests.cs Updates mocks to reflect removal of retry parameters.
tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/SessionHost/SessionHostListCommandTests.cs Updates mocks to reflect removal of retry parameters.
tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/Hostpool/HostpoolListCommandTests.cs Updates mocks to reflect removal of retry parameters.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Services/VirtualDesktopService.cs Removes retry policy parameters and uses AzureService defaults.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Services/IVirtualDesktopService.cs Removes retry policy from the public service contract.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Options/Hostpool/HostpoolListOptions.cs Removes retry option container from command options.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Options/Hostpool/BaseHostPoolOptions.cs Removes retry option container from shared base options.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/SessionHost/SessionHostUserSessionListCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/SessionHost/SessionHostListCommand.cs Stops passing retry policy through to the service.
tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/Hostpool/HostpoolListCommand.cs Stops passing retry policy through to the service.
servers/Azure.Mcp.Server/changelog-entries/remove-retry-policy-options-part9.yaml Documents the breaking change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server tools-VirtualDesktop Azure Virtual Desktop service tools-Workbooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants