[Part 9] Remove RetryPolicyOptions from tools - #3414
Merged
Conversation
Alan Zimmer (alzimmermsft)
requested review from
a team and
Vladimir Stoayanov (vladimisms)
as code owners
August 28, 2026 13:24
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Alan Zimmer (alzimmermsft)
August 28, 2026 13:25
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes RetryPolicyOptions from the Workbooks and Virtual Desktop tool contracts (options, command-to-service calls, and service interfaces), aligning these tools with Azure SDK retry defaults and making the removal explicit as a breaking change.
Changes:
- Removed
RetryPolicyOptions(--retry-*) from Workbooks and Virtual Desktop option models and command/service method signatures. - Updated unit tests to match the new service signatures and removed tests asserting retry options were passed through.
- Added a changelog entry documenting the breaking change.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/UpdateWorkbooksCommandTests.cs | Removes retry-related expectations and a retry-options test case. |
| tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/ShowWorkbooksCommandTests.cs | Updates mocks to reflect removal of retry parameters. |
| tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/ListWorkbooksCommandTests.cs | Updates mocks to reflect removal of retry parameters. |
| tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/DeleteWorkbooksCommandTests.cs | Updates mocks and removes retry-options test case. |
| tools/Azure.Mcp.Tools.Workbooks/tests/Azure.Mcp.Tools.Workbooks.Tests/CreateWorkbooksCommandTests.cs | Updates mocks and removes retry-options test case. |
| tools/Azure.Mcp.Tools.Workbooks/src/Services/WorkbooksService.cs | Removes retry policy parameters and uses AzureService defaults. |
| tools/Azure.Mcp.Tools.Workbooks/src/Services/IWorkbooksService.cs | Removes retry policy from the public service contract. |
| tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/UpdateWorkbooksOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/ShowWorkbooksOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/ListWorkbooksOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/DeleteWorkbookOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.Workbooks/src/Options/Workbook/CreateWorkbookOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/UpdateWorkbooksCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/ShowWorkbooksCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/ListWorkbooksCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/DeleteWorkbooksCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.Workbooks/src/Commands/Workbooks/CreateWorkbooksCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/SessionHost/SessionHostUserSessionListCommandTests.cs | Updates mocks to reflect removal of retry parameters. |
| tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/SessionHost/SessionHostListCommandTests.cs | Updates mocks to reflect removal of retry parameters. |
| tools/Azure.Mcp.Tools.VirtualDesktop/tests/Azure.Mcp.Tools.VirtualDesktop.Tests/Hostpool/HostpoolListCommandTests.cs | Updates mocks to reflect removal of retry parameters. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Services/VirtualDesktopService.cs | Removes retry policy parameters and uses AzureService defaults. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Services/IVirtualDesktopService.cs | Removes retry policy from the public service contract. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Options/Hostpool/HostpoolListOptions.cs | Removes retry option container from command options. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Options/Hostpool/BaseHostPoolOptions.cs | Removes retry option container from shared base options. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/SessionHost/SessionHostUserSessionListCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/SessionHost/SessionHostListCommand.cs | Stops passing retry policy through to the service. |
| tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/Hostpool/HostpoolListCommand.cs | Stops passing retry policy through to the service. |
| servers/Azure.Mcp.Server/changelog-entries/remove-retry-policy-options-part9.yaml | Documents the breaking change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
msalaman
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed custom retry policy options from Virtual Desktop and Workbooks tools.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline