docs(converters): fix copy-pasted comment in _rss_converter - #2423
Open
陈志谦 (simpleqt) wants to merge 1 commit into
Open
docs(converters): fix copy-pasted comment in _rss_converter#2423陈志谦 (simpleqt) wants to merge 1 commit into
陈志谦 (simpleqt) wants to merge 1 commit into
Conversation
The second check handles CANDIDATE_FILE_EXTENSIONS / CANDIDATE_MIME_TYPE_PREFIXES (candidates, not precise matches); the comment was copied verbatim from the precise check above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_rss_converter.pyhad the identical comment "Check for precise mimetypes and file extensions" twice — the second block actually checksCANDIDATE_FILE_EXTENSIONS/CANDIDATE_MIME_TYPE_PREFIXES(candidates, not precise matches). The comment now says "candidate".