Update Docker images to Debian trixie (Python 3.13-slim-trixie) - #2421
Merged
Adam Fourney (afourney) merged 3 commits intoSep 9, 2026
Merged
Adam Fourney (afourney) merged 3 commits into
Adam Fourney (afourney) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused compatibility updates are internally consistent and address the reported build and runtime issues.
Pull request overview
Updates Docker images to supported Debian Trixie and resolves upgrade-related runtime warnings.
Changes:
- Upgrades both images to
python:3.13-slim-trixie. - Replaces the unavailable
exiftoolpackage and disables ONNX telemetry. - Rebuilds MCP settings before server initialization.
File summaries
| File | Description |
|---|---|
Dockerfile |
Updates the primary image and runtime dependencies. |
packages/markitdown-mcp/Dockerfile |
Updates and streamlines the MCP image. |
packages/markitdown-mcp/src/markitdown_mcp/__main__.py |
Resolves the MCP settings forward reference. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves both Dockerfiles from
python:3.13-slim-bullseyetopython:3.13-slim-trixie, plus two small fixes surfaced by the upgrade.Fixes: #2420
Changes
Dockerfile,packages/markitdown-mcp/Dockerfile: base image topython:3.13-slim-trixie.exiftooldoes not exist in trixie (apt-cache policy exiftool→Candidate: (none)), so the build fails atapt-get install. Switched tolibimage-exiftool-perl, which provides/usr/bin/exiftooland matches the existingEXIFTOOL_PATH.ORT_DISABLE_TELEMETRY=1: onnxruntime (via magika) logsFailed to persist telemetry device IDon every run, because the images run asnobody, whose$HOMEis/nonexistent. Setting this removes the noise — relevant for the MCP server, where stray stderr output clutters client logs.packages/markitdown-mcp/src/markitdown_mcp/__main__.py: callSettings.model_rebuild()beforeFastMCP("markitdown")is constructed, to silenceIncompleteFieldDefinitionWarning: Field 'lifespan' has an incomplete definitionfrom newerpydantic-settings. This resolves the forward reference rather than suppressing the warning:Settings.model_fields['lifespan'].annotationgoes from an unresolved string to a realCallable[[FastMCP], AbstractAsyncContextManager[LifespanResultT]] | None. The call must precede first instantiation, since that is when the warning fires.Verification
Both images build and run:
exiftool 13.25andffmpeg 7.1.5-0+deb13u1resolve at the pathsEXIFTOOL_PATH/FFMPEG_PATHpoint to.markitdownCLI converts HTML → Markdown correctly.markitdown-mcpcompletes a full stdio JSON-RPC handshake,tools/list, and a realtools/callconversion. stderr now contains only the normal MCP request log line, no warnings.