fix(ocr): handle PPTX SVG images without a rasterized fallback - #2404
Open
Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Open
fix(ocr): handle PPTX SVG images without a rasterized fallback#2404Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Conversation
Guard on the image blob rather than a nullable stream, build the stream info once so both the LLM and OCR paths describe the image with its real content type, and require markitdown>=0.1.7 for _get_image_info.
PRATHAM KUMAR (rajpratham1)
approved these changes
Sep 7, 2026
PRATHAM KUMAR (rajpratham1)
left a comment
PRATHAM KUMAR (rajpratham1)
left a comment
There was a problem hiding this comment.
The PPTX SVG OCR fix looks correct. The image handling now uses the core PptxConverter logic for SVGs without a rasterized fallback, and the added regression test covers this case. The dependency version is also updated consistently. I don't see any blocking issues in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PptxConverterWithOCRreadsshape.image.blobdirectly, so a deck whose picture is an SVG with no rasterized fallback fails the whole conversion withValueError: no embedded image. The corePptxConverterstopped doing that in #2233, where_get_image_inforesolves the<asvg:svgBlip>relationship whenshape.imageraises.The OCR converter now goes through the core converter for both the image blob and the picture check, so the SVG reaches the OCR service and everything else converts as before. Test uses the same fixture as the core regression test.
Fixes #2399.