Skip to content

Adds response headers to API error - #617

Merged
Andrew Omondi (andrueastman) merged 4 commits into
mainfrom
andrueastman/responseHeaders
Apr 26, 2023
Merged

Andrew Omondi (andrueastman) merged 4 commits into
mainfrom
andrueastman/responseHeaders

Conversation

@andrueastman

@andrueastman Andrew Omondi (andrueastman) commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor

Related to microsoft/kiota#2524
Also closes microsoft/kiota#2241

Case insensitivity of headers is deferred in this PR as the typescript implementation does not cater for this. Furthermore, it's not too clear on when the implementation changed from Map to Record for holding the headers.

Created #618 to track this

@andrueastman
Andrew Omondi (andrueastman) temporarily deployed to build_test April 26, 2023 09:37 — with GitHub Actions Inactive
@andrueastman
Andrew Omondi (andrueastman) temporarily deployed to build_test April 26, 2023 09:37 — with GitHub Actions Inactive
@andrueastman
Andrew Omondi (andrueastman) temporarily deployed to build_test April 26, 2023 09:37 — with GitHub Actions Inactive
@andrueastman
Andrew Omondi (andrueastman) temporarily deployed to build_test April 26, 2023 09:37 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

Generated "test-kiota-typescript-libraries" SDK package:

File count Size (Kb) Unpacked (Kb)
186207 14944.81 189996.52

@github-actions

Copy link
Copy Markdown
Contributor

Generated sample app bundle:

Stat Size (Kb) Parsed Size (Kb) Gzipped (Kb)
37774.05 10828.67 539.46

@andrueastman
Andrew Omondi (andrueastman) deleted the andrueastman/responseHeaders branch April 26, 2023 13:36

This branch was previously deployed

1 inactive deployment
build_test — 8662860f Deployed Apr 26, 2023 by andrueastman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript - Add ResponseStatusCode to API error/exception

2 participants