Repository navigation
fix: send a request body that was set from a stream - #163
Merged
Vincent Biret (baywet) merged 1 commit intoSep 22, 2026
Merged
Conversation
Vincent Biret (baywet)
previously approved these changes
Sep 22, 2026
Andrea Peruffo (andreaTP)
force-pushed
the
fix/stream-request-body
branch
from
September 22, 2026 13:56
4ca33b6 to
7933ea3
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the conflicting framing headers and negative Content-Length handling before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (1)
Andrea Peruffo (andreaTP)
force-pushed
the
fix/stream-request-body
branch
from
September 22, 2026 14:59
7933ea3 to
6c2c969
Compare
Andrea Peruffo (andreaTP)
force-pushed
the
fix/stream-request-body
branch
from
September 22, 2026 17:34
6c2c969 to
34433f2
Compare
set_stream_content takes whatever the caller has, so the body can be an IO, and the adapter called empty? on it, which only a String answers to. The stream is passed to Faraday with its length rather than read into memory, and the request now owns its framing headers instead of leaving whatever the caller sent.
Andrea Peruffo (andreaTP)
force-pushed
the
fix/stream-request-body
branch
from
September 22, 2026 18:03
34433f2 to
3dab001
Compare
Vincent Biret (baywet)
approved these changes
Sep 22, 2026
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


set_stream_content takes whatever the caller has, so the body can be an IO, and the adapter called empty? on it, which only a String answers to.