Repository navigation
feat: serialize scalar request bodies and enum collections - #158
Merged
Vincent Biret (baywet) merged 1 commit intoSep 18, 2026
Merged
Vincent Biret (baywet) merged 1 commit into
Vincent Biret (baywet) merged 1 commit into
Conversation
Andrea Peruffo (andreaTP)
commented
Sep 18, 2026
Contributor
- set_content_from_scalar did not exist, so a scalar request body went through set_content_from_parsable and failed to serialize
- write_collection_of_enum_values did not exist
- a primitive collection written as the document root kept only its last element, each one overwrote the root in turn
Vincent Biret (baywet)
previously approved these changes
Sep 18, 2026
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The critical scalar root serialization issue and two moderate issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds scalar request-body serialization, enum collection support, and root primitive collection handling.
Changes:
- Adds scalar type dispatch and enum collection APIs.
- Updates JSON collection/root serialization.
- Adds scalar and collection specs.
File summaries
| File | Summary |
|---|---|
components/serialization/json/spec/json_enum_collection_writer_spec.rb |
Tests enum and primitive collection serialization. |
components/serialization/json/lib/microsoft_kiota_serialization_json/json_serialization_writer.rb |
Moderate issue (3 votes): false and nil values are mishandled in root primitive collections. |
components/abstractions/spec/request_information_scalar_spec.rb |
Moderate issue (2 votes): missing library require causes isolated execution to raise NameError. |
components/abstractions/lib/microsoft_kiota_abstractions/serialization/serialization_writer.rb |
Adds the enum collection writer contract. |
components/abstractions/lib/microsoft_kiota_abstractions/request_information.rb |
Critical issue (1 vote): date/time/UUID scalar roots can serialize as {} instead of scalar JSON values. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- set_content_from_scalar did not exist, so a scalar request body went through set_content_from_parsable and failed to serialize
- write_collection_of_enum_values did not exist
- a primitive collection written as the document root kept only its last element, each one overwrote the root in turn
- the guid, date, time, date time and duration writers returned the converted scalar for a nil key without registering it as the root, so those bodies serialized to {}
Andrea Peruffo (andreaTP)
force-pushed
the
feat/scalar-body-and-enum-collections
branch
from
September 18, 2026 12:09
e678317 to
37ec574
Compare
Vincent Biret (baywet)
approved these changes
Sep 18, 2026
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.