Skip to content

chore: remove SonarCloud integration - #2255

Merged
Vincent Biret (baywet) merged 1 commit into
mainfrom
chore/remove-sonar-20261116
Nov 16, 2026
Merged

Vincent Biret (baywet) merged 1 commit into
mainfrom
chore/remove-sonar-20261116

Conversation

@baywet

Copy link
Copy Markdown
Member

Summary

  • Delete the SonarCloud analysis workflow.
  • Remove the root/subproject SonarQube Gradle plugin, version-catalog entry, SonarCloud project settings, and skip-compile property.
  • Preserve JaCoCo coverage/report generation, tests, SpotBugs, Spotless, and all other CI workflows. No Maven Sonar integration or badges were present.

Validation

  • PASS: gradlew.bat --no-daemon build spotlessCheck using Java 21 (115 tasks executed); 449 tests across 37 suites, zero failures/errors/skips; coverage reports generated.
  • PASS: gradlew.bat --no-daemon build -Pjava8=true -Porg.gradle.java.installations.paths=<portable-JDK8> (155 tasks: 40 executed, 115 up-to-date). Java 8 compatibility projects contain no test sources; tests were exercised by the main build above.
  • PASS: automated full tracked-file scan (including hidden files) finds no remaining Sonar integration references; exactly four expected files changed; all eight JaCoCo build files unchanged.
  • PASS: version-catalog TOML and all seven remaining workflow YAML files parse; git diff --check passes. No surviving workflow was edited.

Limitations / existing issues

  • Java was initially missing; portable Java 21 and Java 8 toolchains were downloaded solely for validation and removed afterward. No repository tooling/dependencies were added.
  • Full actionlint -shellcheck= -pyflakes= reports the existing undefined inputs.componentName in the unchanged build workflow (line 37); confirmed identical against the base version.
  • Builds emit existing Gradle deprecation/Javadoc warnings. Android builds were not run.

Remove the SonarCloud workflow, Gradle plugin and project settings while preserving JaCoCo coverage, SpotBugs and Spotless.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a2e376ca-1b60-48d9-a217-6740cb920e4d
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner November 16, 2026 14:25
Copilot AI balanced review requested due to automatic review settings November 16, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deleting the SonarCloud workflow removes CI execution of the main JVM unit tests and JaCoCo coverage generation, which the surviving workflows do not replace.

No open issues 🎉

What changed in this PR

Removes SonarCloud integration from Kiota Java’s Gradle configuration and CI, while leaving the existing coverage and quality-tool configuration unchanged.

Changes:

  • Deletes the SonarCloud analysis workflow.
  • Removes the root and subproject SonarQube plugin configuration and version-catalog entry.
  • Removes SonarCloud project settings and the skip-compile property.
File Description
settings.gradle Removes the Sonar skip-compile property.
gradle/​libs.versions.toml Removes the SonarQube plugin entry.
build.gradle Removes SonarQube plugin application and SonarCloud settings.
.github/​workflows/​sonarcloud.yml Deletes the build-and-analysis workflow.

Review effort: Balanced

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the SonarCloud workflow, Gradle plugin, configuration, and version-catalog cleanup. The independent Gradle build/test workflow remains intact. No blocking findings.

@github-project-automation github-project-automation Bot moved this to In Progress 🚧 in Kiota Nov 16, 2026
@baywet
Vincent Biret (baywet) added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 15efefe Nov 16, 2026
9 checks passed
@baywet
Vincent Biret (baywet) deleted the chore/remove-sonar-20261116 branch November 16, 2026 18:52
@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Done ✔️ in Kiota Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

3 participants