sr: Handle restore transaction atomically - #472
Open
Cameron E Baird (Camelron) wants to merge 1 commit into
Open
Conversation
We have several lifecycle bugs where, if any operation times out or otherwise fails during the sandbox or workload adoption, we don't exit gracefully and leave a stuck shim + clh process on the node. Handle these by making failures during the restore path fatal, exiting the shim with errors. Currently a failure during CreateContainer is handled as a sandbox-level fault and the whole shim exits as well. Possibly we'll have to refine this to allow CreateContainer retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have several lifecycle bugs where, if any operation times out or otherwise fails during the sandbox or workload adoption, we don't exit gracefully and leave a stuck shim + clh process on the node.
Handle these by making failures during the restore path fatal, exiting the shim with errors.
Currently a failure during CreateContainer is handled as a sandbox-level fault and the whole shim exits as well. Possibly we'll have to refine this to allow CreateContainer retries.