Stop writing default dependentChangeType in change files - #1384
Open
Elizabeth Craig (ecraig12345) wants to merge 1 commit into
Open
Stop writing default dependentChangeType in change files#1384Elizabeth Craig (ecraig12345) wants to merge 1 commit into
Elizabeth Craig (ecraig12345) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Elizabeth Craig (ecraig12345)
August 8, 2026 09:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Moves default dependentChangeType handling from change-file generation to bump calculation while preserving explicit overrides.
Changes:
- Omits default dependent bump values from generated change files.
- Applies
noneorpatchdefaults during bumping. - Updates validation, tests, documentation, fixtures, and change-file guidance.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
skills/beachball-change-file/SKILL.md |
Updates change-file generation guidance. |
packages/beachball/src/validation/validate.ts |
Allows omitted dependent change types. |
packages/beachball/src/types/ChangeInfo.ts |
Makes the field optional and documents defaults. |
packages/beachball/src/changefile/promptForChange.ts |
Writes only explicit overrides. |
packages/beachball/src/bump/updateRelatedChangeType.ts |
Applies defaults during bumping. |
packages/beachball/src/__tests__/changefile/promptForChange_getChangeFileInfoFromResponse.test.ts |
Tests field omission. |
packages/beachball/src/__tests__/bump/updateRelatedChangeType.test.ts |
Tests bump-time defaults. |
packages/beachball/src/__functional__/changefile/readChangeFiles.test.ts |
Updates expected change-file contents. |
packages/beachball/src/__fixtures__/changeFiles.ts |
Removes the fixture’s explicit default. |
docs/overview/v3-migration.md |
Documents the v3 behavior change. |
change/beachball-cddc125a-9fbf-42ac-9343-261e46698091.json |
Records the Beachball breaking change. |
change/@microsoft-beachball-change-file-skill-ba33783c-4380-41f5-baf6-4c49507c2837.json |
Records the skill update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no custom value is specified for
dependentChangeTypewhen generating change files, omit the default value from the written file, and instead fill it in during bumping.This is related to #947 and opens up options for some potential future improvements (plus reducing the amount written to many small files in a large repo isn't a bad thing).